mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 64003: Made quota resource allocation fine-grained.
Date Wed, 20 Dec 2017 02:10:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64003/#review194204
-----------------------------------------------------------



FAIL: Failed to apply the current review.

Failed command: `python.exe .\support\apply-reviews.py -n -r 64003`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64003

Relevant logs:

- [apply-review-64003-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64003/logs/apply-review-64003-stderr.log):

```
Traceback (most recent call last):
  File ".\support\apply-reviews.py", line 434, in <module>
    main()
  File ".\support\apply-reviews.py", line 429, in main
    reviewboard(options)
  File ".\support\apply-reviews.py", line 419, in reviewboard
    apply_review(options)
  File ".\support\apply-reviews.py", line 160, in apply_review
    commit_patch(options)
  File ".\support\apply-reviews.py", line 271, in commit_patch
    message.write(data['message'])
UnicodeEncodeError: 'ascii' codec can't encode character u'\u2019' in position 112: ordinal
not in range(128)
```

- Mesos Reviewbot Windows


On Dec. 20, 2017, 2:06 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64003/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2017, 2:06 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Jie Yu, and Michael Park.
> 
> 
> Bugs: MESOS-7099
>     https://issues.apache.org/jira/browse/MESOS-7099
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allocator now does fine-grained resource allocation up
> to the role’s quota limit. And a role's quota is only
> considered to be satisfied if all of its quota resources
> are satisfied. Previously, a role's quota is considered
> to be met if any one of its quota resources reaches the limit.
> 
> Also fixed a few affected allocator tests.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 1c767f7f778819dcfa6eff51765163aec1b70a2d

>   src/tests/hierarchical_allocator_tests.cpp 173e4fbac184ad8d40c8adba19ad64225f11f1f2

> 
> 
> Diff: https://reviews.apache.org/r/64003/diff/4/
> 
> 
> Testing
> -------
> 
> Fixed a few broken tests due to this patch.
> make check.
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message