mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Review Request 64725: Refactred `UriVolumeProfileAdaptor` and `VolumeProfileTest`.
Date Tue, 19 Dec 2017 22:17:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64725/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler, Jie Yu, and Joseph Wu.


Repository: mesos


Description
-------

This patch moves `uri_volume_profile.proto` to `volume_profile.proto`
and made it a Mesos internal protobuf, to avoid loading the same
protobuf twice when loading the `UriVolumeProfileAdaptor` module.


Diffs
-----

  src/Makefile.am 4623cfcdd0920367043db47f7ab261496996f33a 
  src/csi/uri_volume_profile.proto a3dfc5da4ea4b226b3e8fc06c050300a56d4637d 
  src/csi/utils.hpp b49fa5906eab9a8081b661d4bb76c6ea329c3af7 
  src/csi/utils.cpp bae4654db8ef8136911cd36f669fb416793ee05f 
  src/resource_provider/uri_volume_profile.hpp e6588f1bd70ede291fa870c8e544bea72228b960 
  src/resource_provider/uri_volume_profile.cpp 9dc0e6cff0a452887080248b4547c36034a25b40 
  src/resource_provider/volume_profile_utils.hpp PRE-CREATION 
  src/resource_provider/volume_profile_utils.cpp PRE-CREATION 
  src/slave/flags.hpp d5f95fe598ee858321a189fd5bb8b046708ffb27 
  src/slave/flags.cpp 69f37fef60bfd301d1b835b012da0b289838b7b9 
  src/slave/slave.hpp c1322a34761ccfea93470852c818d0c0b5015399 
  src/slave/slave.cpp 580ad193aa1a63b2bf4cfd877dd1b5e74683ee82 
  src/tests/volume_profile_tests.cpp 41b43cbb617ed77d1ce8837b278a9b409f2d386c 


Diff: https://reviews.apache.org/r/64725/diff/1/


Testing
-------

sudo make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message