mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Review Request 64713: Fixed a crash when resubscribing resource providers.
Date Tue, 19 Dec 2017 15:14:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64713/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Jie Yu.


Bugs: MESOS-8346
    https://issues.apache.org/jira/browse/MESOS-8346


Repository: mesos


Description
-------

If a resource provider resubscribed while its old HTTP connection was
still open, the agent would crash, as a continuation would be called
erroneously. This continuation is now only called when a HTTP connection
is closed by a remote side (i.e. the resource provider) and not when
the resource provider manager closes the connection.


Diffs
-----

  src/resource_provider/manager.cpp 2a167aa5c50598758cab4ab6c13f1b1e33e692dd 
  src/tests/resource_provider_manager_tests.cpp 4e86016a450c30fea90e9c6e5c1f2f1aab5f42c0 


Diff: https://reviews.apache.org/r/64713/diff/1/


Testing
-------

make check


Thanks,

Jan Schlicht


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message