mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 64297: Updated modules documentation with some more details.
Date Tue, 19 Dec 2017 09:28:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64297/#review194134
-----------------------------------------------------------




docs/hook.md
Lines 30 (patched)
<https://reviews.apache.org/r/64297/#comment272867>

    You use `slave` instead of `Agent` in other parts of this file.



docs/hook.md
Lines 56 (patched)
<https://reviews.apache.org/r/64297/#comment272868>

    This document contains `within slave` and `within the slave`, using the same wording every
time would be cleaner.



docs/hook.md
Lines 61 (patched)
<https://reviews.apache.org/r/64297/#comment272869>

    The `a` can be removed.



docs/hook.md
Lines 72 (patched)
<https://reviews.apache.org/r/64297/#comment272870>

    s/`docker`/`Docker`



docs/hook.md
Lines 82 (patched)
<https://reviews.apache.org/r/64297/#comment272871>

    s/`the hook loaded last`/`the last hook loaded`



docs/hook.md
Lines 157 (patched)
<https://reviews.apache.org/r/64297/#comment272872>

    s/`attributes for`/`attributes of`



docs/modules.md
Lines 135 (patched)
<https://reviews.apache.org/r/64297/#comment272873>

    Even if no dedicated section exists for this module yet, could a one-liner description
be added in this array? Same for the ones at the end of the array.



docs/modules.md
Lines 141 (patched)
<https://reviews.apache.org/r/64297/#comment272866>

    s/`implementubg`/`implementing`


- Armand Grillet


On Dec. 4, 2017, 1:25 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64297/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2017, 1:25 p.m.)
> 
> 
> Review request for mesos, Armand Grillet, Benjamin Bannier, and Kapil Arya.
> 
> 
> Bugs: MESOS-8016
>     https://issues.apache.org/jira/browse/MESOS-8016
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added mention of HTTP authenticatee module. Added mention of
> authorizer modules. Added details around hook modules.
> 
> 
> Diffs
> -----
> 
>   docs/hook.md PRE-CREATION 
>   docs/modules.md c5231e242cfe42834beeb98846c9308e0fd8dff3 
> 
> 
> Diff: https://reviews.apache.org/r/64297/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message