mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 64612: Added flag to pass VolumeProfileAdaptor module to SLRP.
Date Fri, 15 Dec 2017 23:26:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64612/#review193997
-----------------------------------------------------------




src/resource_provider/local.cpp
Lines 39 (patched)
<https://reviews.apache.org/r/64612/#comment272690>

    It's weird that LocalResourceProvider needs to be aware `volumeProfileAdaptor` which is
very StorageLocalResourceProvider specific.
    
    It's more appropriate to instantiate that in StorageLocalResourceProvider and make it
a singleton.
    
    probably passing the agent flags all the way to this method (or use `Parameters` to pass
in provider specifc parameters).


- Jie Yu


On Dec. 14, 2017, 1:15 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64612/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2017, 1:15 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jie Yu.
> 
> 
> Bugs: MESOS-8251
>     https://issues.apache.org/jira/browse/MESOS-8251
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This adds an agent flag to choose the VolumeProfileAdaptor module
> to load and passes this information down to the storage resource
> providers. A single module can potentially be used by multiple
> storage resource providers.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/daemon.hpp a6d0013fa3645fd2b705351a86679f7fba13e7e3 
>   src/resource_provider/daemon.cpp f160a87c37d975d632db05694ca7b59f1d275821 
>   src/resource_provider/local.hpp 20bcc78d3fe847e03526fa59116bdbac92ec1e29 
>   src/resource_provider/local.cpp ae23c2000b7941aad92d3b83e4e905bdf042ebe8 
>   src/resource_provider/storage/provider.hpp 5a371b19289c6e39fedd4cda65fa8be432d095e6

>   src/resource_provider/storage/provider.cpp f00fe58e12dcaa911ab3d05c3d7719c65a1484fb

>   src/slave/flags.hpp 5918484825c3c813883c42465f3e5a5693d6a2cd 
>   src/slave/flags.cpp d4b95b7542733b22299bc19235cf99220534c022 
> 
> 
> Diff: https://reviews.apache.org/r/64612/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> Basically just a plumbing change to pass the module into the SLRP.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message