mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 64639: Supported getting all containers in the agent API.
Date Fri, 15 Dec 2017 21:55:37 GMT


> On Dec. 15, 2017, 9:46 p.m., Greg Mann wrote:
> > src/slave/http.cpp
> > Lines 2275-2276 (original), 2380-2384 (patched)
> > <https://reviews.apache.org/r/64639/diff/2/?file=1918457#file1918457line2381>
> >
> >     Nit: these fit on one line.

The second one does not :( thus the change.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64639/#review193965
-----------------------------------------------------------


On Dec. 15, 2017, 4:56 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64639/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2017, 4:56 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Joseph Wu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Supported getting all containers in the agent API.
> 
> 
> Diffs
> -----
> 
>   src/internal/evolve.cpp 6ce6150ee60e8db6f6a0c8febefb781d5c1daf1f 
>   src/slave/containerizer/mesos/containerizer.cpp 7ab0b07f689f872573ca458ae47cd6426ebc0365

>   src/slave/http.hpp 9ca061758da90f799fd012d3a9b717b8e3ad70f0 
>   src/slave/http.cpp ed22b9f6bfa1c480a0672ce25d364bba6e33a200 
>   src/tests/agent_container_api_tests.cpp c2c15eb4812d8f45d54f96cf43bbf0c77a75578a 
> 
> 
> Diff: https://reviews.apache.org/r/64639/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message