mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 64639: Supported getting all containers in the agent API.
Date Fri, 15 Dec 2017 21:46:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64639/#review193965
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/http.cpp
Lines 2327 (patched)
<https://reviews.apache.org/r/64639/#comment272658>

    s/bool/const bool/



src/slave/http.cpp
Lines 2331 (patched)
<https://reviews.apache.org/r/64639/#comment272655>

    Nit:
    "MesosContainerizer-specific methods"



src/slave/http.cpp
Lines 2341-2342 (patched)
<https://reviews.apache.org/r/64639/#comment272659>

    Nit: fits on one line.



src/slave/http.cpp
Lines 2275-2276 (original), 2380-2384 (patched)
<https://reviews.apache.org/r/64639/#comment272673>

    Nit: these fit on one line.



src/tests/agent_container_api_tests.cpp
Lines 426 (patched)
<https://reviews.apache.org/r/64639/#comment272674>

    Looks like this param is only set to `true` currently, should we just set it in the function
body like `show_standalone`?


- Greg Mann


On Dec. 15, 2017, 4:56 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64639/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2017, 4:56 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Joseph Wu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Supported getting all containers in the agent API.
> 
> 
> Diffs
> -----
> 
>   src/internal/evolve.cpp 6ce6150ee60e8db6f6a0c8febefb781d5c1daf1f 
>   src/slave/containerizer/mesos/containerizer.cpp 7ab0b07f689f872573ca458ae47cd6426ebc0365

>   src/slave/http.hpp 9ca061758da90f799fd012d3a9b717b8e3ad70f0 
>   src/slave/http.cpp ed22b9f6bfa1c480a0672ce25d364bba6e33a200 
>   src/tests/agent_container_api_tests.cpp c2c15eb4812d8f45d54f96cf43bbf0c77a75578a 
> 
> 
> Diff: https://reviews.apache.org/r/64639/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message