mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 64621: Fixed a corner case for pre-existing volumes created by old RPs.
Date Fri, 15 Dec 2017 21:43:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64621/
-----------------------------------------------------------

(Updated Dec. 15, 2017, 9:43 p.m.)


Review request for mesos, Jie Yu and Joseph Wu.


Changes
-------

Addressed comments.


Repository: mesos


Description
-------

When an agent failed over and registered as a new one, the RP will be
registered as a new one as well, but it could pick up the checkpointed
states for volumes created by an old RP as pre-existing volumes. We
should use the checkpointed capabilities for these volumes instead of
using the default mount or block capability.


Diffs (updated)
-----

  src/resource_provider/storage/provider.cpp 158b6b408002209aa9a79a6772da30c984aad61a 


Diff: https://reviews.apache.org/r/64621/diff/2/

Changes: https://reviews.apache.org/r/64621/diff/1-2/


Testing
-------

sudo make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message