mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 64621: Fixed a corner case for pre-existing volumes created by old RPs.
Date Fri, 15 Dec 2017 19:44:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64621/#review193963
-----------------------------------------------------------


Fix it, then Ship it!





src/resource_provider/storage/provider.cpp
Lines 2448-2449 (original), 2445-2446 (patched)
<https://reviews.apache.org/r/64621/#comment272647>

    When you do `profiles.at`, you assumes that the profile already exist? Can you add some
CHECK if that's your assumption? Ditto other places.


- Jie Yu


On Dec. 14, 2017, 7:34 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64621/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2017, 7:34 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When an agent failed over and registered as a new one, the RP will be
> registered as a new one as well, but it could pick up the checkpointed
> states for volumes created by an old RP as pre-existing volumes. We
> should use the checkpointed capabilities for these volumes instead of
> using the default mount or block capability.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/provider.cpp 17acf1b430b81e31bd97b117a44477eebab7e6f4

> 
> 
> Diff: https://reviews.apache.org/r/64621/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message