mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 64353: Added example VolumeProfile module.
Date Fri, 15 Dec 2017 19:29:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64353/
-----------------------------------------------------------

(Updated Dec. 15, 2017, 11:29 a.m.)


Review request for mesos, Chun-Hung Hsiao and Jie Yu.


Changes
-------

Fixed ability to load `file://` for the `--uri` flag correctly.  This also relaxed the flag
a bit, so it is possible to specify a path like `/path/to/thing` rather than `file:///path/to/thing`.


Bugs: MESOS-8251
    https://issues.apache.org/jira/browse/MESOS-8251


Repository: mesos


Description
-------

This example module shows how a VolumeProfile module might be
implemented (and is a viable module in its own right).  The module
can be configured to fetch a map of profiles from a URI (`file://` or
`http(s)://`) and possibly cache this item for some time.


Diffs (updated)
-----

  src/Makefile.am f5a4edd245e8d6535502e951ecaa526c2bae25f9 
  src/resource_provider/uri_volume_profile.hpp PRE-CREATION 
  src/resource_provider/uri_volume_profile.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/64353/diff/5/

Changes: https://reviews.apache.org/r/64353/diff/4-5/


Testing
-------

See end of chain.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message