mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 64650: Made resource provider driver start explicit.
Date Fri, 15 Dec 2017 15:10:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64650/#review193914
-----------------------------------------------------------



FAIL: Some Mesos tests failed.

Reviews applied: `['64650']`

Failed command: `D:\DCOS\mesos\src\mesos-tests.exe --verbose`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64650

Relevant logs:

- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64650/logs/mesos-tests-stdout.log):

```

[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN      ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[       OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2280 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2303 ms total)

[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN      ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[       OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2373 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2401 ms total)

[----------] Global test environment tear-down
[==========] 835 tests from 85 test cases ran. (311940 ms total)
[  PASSED  ] 825 tests.
[  FAILED  ] 10 tests, listed below:
[  FAILED  ] OfferOperationStatusUpdateManagerTest.UpdateAndAckNonTerminalUpdate
[  FAILED  ] OfferOperationStatusUpdateManagerTest.RecoverCheckpointedStream
[  FAILED  ] OfferOperationStatusUpdateManagerTest.RecoverEmptyFile
[  FAILED  ] OfferOperationStatusUpdateManagerTest.RecoverTerminatedStream
[  FAILED  ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdate
[  FAILED  ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdateAfterRecover
[  FAILED  ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAck
[  FAILED  ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAckAfterRecover
[  FAILED  ] OfferOperationStatusUpdateManagerTest.NonStrictRecoveryCorruptedFile
[  FAILED  ] OfferOperationStatusUpdateManagerTest.UpdateLatestWhenResending

10 FAILED TESTS
  YOU HAVE 205 DISABLED TESTS

```

- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64650/logs/mesos-tests-stderr.log):

```
I1215 15:10:34.312325  3196 master.cpp:10160] Updating the state of task 4132dc43-9dd7-4636-97fc-767bcd315ef0
of framework 06edae8c-bb37-40cc-ad12-026263f09cd3-0000 (latest state: TASK_KILLED, status
update I1215 15:10:33.663337  9916 exec.cpp:162] Version: 1.5.0
I1215 15:10:33.685343  7424 exec.cpp:237] Executor registered on agent 06edae8c-bb37-40cc-ad12-026263f09cd3-S0
I1215 15:10:33.688338  8708 executor.cpp:171] Received SUBSCRIBED event
I1215 15:10:33.692342  8708 executor.cpp:175] Subscribed executor on build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I1215 15:10:33.693341  8708 executor.cpp:171] Received LAUNCH event
I1215 15:10:33.697350  8708 executor.cpp:638] Starting task 4132dc43-9dd7-4636-97fc-767bcd315ef0
I1215 15:10:33.774338  8708 executor.cpp:478] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe
launch <POSSIBLY-SENSITIVE-DATA>'
I1215 15:10:34.285323  8708 executor.cpp:651] Forked command at 8940
I1215 15:10:34.314326  3796 exec.cpp:435] Executor asked to shutdown
I1215 15:10:34.315325  9968 executor.cpp:171] Received SHUTDOWN event
I1215 15:10:34.315325  9968 executor.cpp:748] Shutting down
I1215 15:10:34.315325  9968 executor.cpp:855] Sending SIGTERM to process tree at pid 8state:
TASK_KILLED)
I1215 15:10:34.312325  3944 slave.cpp:3401] Shutting down framework 06edae8c-bb37-40cc-ad12-026263f09cd3-0000
I1215 15:10:34.312325  3944 slave.cpp:6109] Shutting down executor '4132dc43-9dd7-4636-97fc-767bcd315ef0'
of framework 06edae8c-bb37-40cc-ad12-026263f09cd3-0000 at executor(1)@10.3.1.11:50472
I1215 15:10:34.314326  3944 slave.cpp:909] Agent terminating
W1215 15:10:34.314326  3944 slave.cpp:3397] Ignoring shutdown framework 06edae8c-bb37-40cc-ad12-026263f09cd3-0000
because it is terminating
I1215 15:10:34.314326  3196 master.cpp:10266] Removing task 4132dc43-9dd7-4636-97fc-767bcd315ef0
with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated:
*):[31000-32000] of framework 06edae8c-bb37-40cc-ad12-026263f09cd3-0000 on agent 06edae8c-bb37-40cc-ad12-026263f09cd3-S0
at slave(327)@10.3.1.11:50451 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1215 15:10:34.317353  3196 master.cpp:1305] Agent 06edae8c-bb37-40cc-ad12-026263f09cd3-S0
at slave(327)@10.3.1.11:50451 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
disconnected
I1215 15:10:34.317353  3196 master.cpp:3364] Disconnecting agent 06edae8c-bb37-40cc-ad12-026263f09cd3-S0
at slave(327)@10.3.1.11:50451 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1215 15:10:34.317353  8756 containerizer.cpp:2337] Destroying container 7b1b72fd-ac34-43a0-a576-156fee96aafd
in RUNNING state
I1215 15:10:34.317353  3288 hierarchical.cpp:344] Removed framework 06edae8c-bb37-40cc-ad12-026263f09cd3-0000
I1215 15:10:34.317353  3196 master.cpp:3383] Deactivating agent 06edae8c-bb37-40cc-ad12-026263f09cd3-S0
at slave(327)@10.3.1.11:50451 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1215 15:10:34.317353  8756 containerizer.cpp:2939] Transitioning the state of container 7b1b72fd-ac34-43a0-a576-156fee96aafd
from RUNNING to DESTROYING
I1215 15:10:34.318325  3288 hierarchical.cpp:766] Agent 06edae8c-bb37-40cc-ad12-026263f09cd3-S0
deactivated
I1215 15:10:34.318325  8756 launcher.cpp:156] Asked to destroy container 7b1b72fd-ac34-43a0-a576-156fee96aafd
I1215 15:10:34.403566  1136 containerizer.cpp:2788] Container 7b1b72fd-ac34-43a0-a576-156fee96aafd
has exited
I1215 15:10:34.432560  4480 master.cpp:1147] Master terminating
I1215 15:10:34.434569  3196 hierarchical.cpp:609] Removed agent 06edae8c-bb37-40cc-ad12-026263f09cd3-S0
I1215 15:10:34.769572  9184 process.cpp:887] Failed to accept socket: future discarded
```

- Mesos Reviewbot Windows


On Dec. 15, 2017, 1:29 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64650/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2017, 1:29 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The driver for HTTP connections of resource providers is implemented
> as an actor which takes callbacks. It previously started listening for
> and handling of events on creation. We typically store drivers as
> member of resource providers.
> 
> This setup is in general problematic since it e.g., becomes impossible
> to write safe callbacks using internal resource provider state; it was
> e.g., impossible to write a safe callback using the member driver to
> send calls. This is due to a race between initialization of the member
> driver and a newly created driver starting to handle events and
> triggering callbacks making use of a not yet initialized member driver
> variable. As a concrete example, with a 'MockResourceProvider' holding
> a 'std::unique_ptr<Driver>' member tests would regularly hit this
> race, even though the time window between creating a temporary to
> assign to the member and the assignment appeared to be small.
> 
> This patch introduces an explicit 'start' method to the driver which
> is to be used to explicitly start processing of events by the driver.
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/resource_provider.hpp 006889a090d5d211cf8e03d67c849753639207f3 
>   src/resource_provider/driver.cpp 62c4ca11e40fae7c2da929511ce304908e4e9256 
>   src/resource_provider/http_connection.hpp 207120a6d28d231276b34ce30e6ae2f640884e19

>   src/resource_provider/storage/provider.cpp 17acf1b430b81e31bd97b117a44477eebab7e6f4

>   src/tests/mesos.hpp 6207d621f0496c69f34280da2246d7d9967ba55b 
> 
> 
> Diff: https://reviews.apache.org/r/64650/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> Without this patch `ContentType/ResourceProviderManagerHttpApiTest.ConvertResources/0`
fails after < 30 iterations; with this patch it passes > 2000 iterations.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message