mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 64624: Added standalone isolator capability.
Date Fri, 15 Dec 2017 11:58:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64624/#review193905
-----------------------------------------------------------


Ship it!




LGTM!

- Gilbert Song


On Dec. 14, 2017, 12:19 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64624/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2017, 12:19 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-7302
>     https://issues.apache.org/jira/browse/MESOS-7302
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Recently, we introduced the standalone container suport (MESOS-7302).
> Some isolators might not be able to handle standalone containers.
> Therefore, we introduce an isolator capability (similar to nesting
> capability) so that we won't try to invoke those isolators that do not
> support standalone containers when dealing with a standalone container.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/isolator.hpp c52563fa055ae4d949f40db53c0f2eaec1cf9036 
>   src/slave/containerizer/mesos/containerizer.hpp 965e183bb5c54f31d90e910edd35313ab380cea9

>   src/slave/containerizer/mesos/containerizer.cpp 7ab0b07f689f872573ca458ae47cd6426ebc0365

>   src/slave/containerizer/mesos/io/switchboard.hpp 520a6ef7a888ad350909ca60adbb493970e971b7

>   src/slave/containerizer/mesos/io/switchboard.cpp af8fbe8ed6e90bfaa650fa5c0ac5fa655e6e3afd

>   src/slave/containerizer/mesos/isolator.hpp aaad346fce68b1fae1d84331bade358ebfe3db87

>   src/slave/containerizer/mesos/isolator.cpp ccdcb9a3710f26dbc23042d70cae3fcf4cbd527f

>   src/slave/containerizer/mesos/isolators/appc/runtime.hpp 8d225878ddbd04e4297b84c9ff782a994986aa4e

>   src/slave/containerizer/mesos/isolators/appc/runtime.cpp 535ea1adb6dc8f9444aeb760a7c69cacc9e4bc38

>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 229bafc088c1c8f46384b8853516c0ebfce8593e

>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp c0ebc4e988a56d954e6c5831d931967331251f32

>   src/slave/containerizer/mesos/isolators/docker/runtime.hpp 642dd53a8028d26b0a8c7429a502d33db26838b7

>   src/slave/containerizer/mesos/isolators/docker/runtime.cpp 93394f899b2a53c7dd4f129e205351e7194a65f2

>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 2e64d055e146719363a4118c0a63779524f7d9e5

>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 6efdc75315dc68a73687c9b22ffe2c38136ca51f

>   src/slave/containerizer/mesos/isolators/environment_secret.hpp b98e8fe0d297d6c813a68e1d85681957d6577eb4

>   src/slave/containerizer/mesos/isolators/environment_secret.cpp 5b0b2fc7e0667c5ba4fabcd45330d9e55a35fb6a

>   src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 6584d1e1cef410861df7b2dfd4006f1bb8a71698

>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp aa939e34abdb4b1dd98a0c32ce1e39ae76e062b8

>   src/slave/containerizer/mesos/isolators/gpu/isolator.hpp f3103a7ea2ad937ca1968faa2b8c6aa390ab6237

>   src/slave/containerizer/mesos/isolators/gpu/isolator.cpp 7b664267bf7f39552c8b7aea95a966845de966f1

>   src/slave/containerizer/mesos/isolators/linux/capabilities.hpp b9862a23490f1383742e6539c158efc2962497de

>   src/slave/containerizer/mesos/isolators/linux/capabilities.cpp 21d851e33e69b35a46d262276c2a87a256dd0fd9

>   src/slave/containerizer/mesos/isolators/namespaces/ipc.hpp 98504079e336aa4f9c6dd8cf8bd0690e79e19f29

>   src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp 2d89d598d24e3bcf01d652ce3f586c9e3ccfc20b

>   src/slave/containerizer/mesos/isolators/namespaces/pid.hpp 6b4ba06c1067910a48fad4309e5fce156f6cd808

>   src/slave/containerizer/mesos/isolators/namespaces/pid.cpp 4f8253b58018581e022eb1832b9b07703cbd318d

>   src/slave/containerizer/mesos/isolators/posix/disk.hpp 68d9744de8fbff60f23dbd59bc242ad5f95256f6

>   src/slave/containerizer/mesos/isolators/posix/disk.cpp eb2302516d6e77873c22f279375e7659126b289c

>   src/slave/containerizer/mesos/isolators/posix/rlimits.hpp 0bce083a17e221400f1426ee64c87c3b48dac10a

>   src/slave/containerizer/mesos/isolators/posix/rlimits.cpp 0136652d03c987416b725e2a596358c714561110

>   src/slave/containerizer/mesos/isolators/volume/host_path.hpp 08c3d5f6a8643172d5cb3a629161e8aea9f0e4b5

>   src/slave/containerizer/mesos/isolators/volume/host_path.cpp 3f3f28068a4d1e68f5bfd4ba97ef9193845581a4

>   src/slave/containerizer/mesos/isolators/volume/image.hpp 8465bb5e14c6450e7dd6c82411fa9fdeeb517aa8

>   src/slave/containerizer/mesos/isolators/volume/image.cpp 15e242d5d6550928fae9d583a26fd02f9df3973f

>   src/slave/containerizer/mesos/isolators/volume/sandbox_path.hpp 12fab61855cdbdbd4bbbdad2335722448a5b7b07

>   src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp d8e41c459fcc68d395358322350206f71d47f18c

>   src/slave/containerizer/mesos/isolators/volume/secret.hpp 2680345c974c5c20bef1f2715677b37f6bead27f

>   src/slave/containerizer/mesos/isolators/volume/secret.cpp 8071e4ee808bc825b13a6291767778d6ce3c2746

>   src/slave/containerizer/mesos/isolators/windows/cpu.hpp b996b078b2b40df0950f60273000c93414e2c6d3

>   src/slave/containerizer/mesos/isolators/windows/cpu.cpp 782c7adef6a931ce1d3bc4a26713d232402dd797

>   src/slave/containerizer/mesos/isolators/windows/mem.hpp 8c4e3fe3c94e127021d4896944536e102cef1e75

>   src/slave/containerizer/mesos/isolators/windows/mem.cpp c6a2ded30f4a59aa564cc47026b4e0559bc07146

> 
> 
> Diff: https://reviews.apache.org/r/64624/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message