mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 64575: Added containerClass() to MesosContainerizerProcess::Container.
Date Fri, 15 Dec 2017 10:19:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64575/#review193896
-----------------------------------------------------------




src/slave/containerizer/mesos/containerizer.hpp
Lines 358-359 (patched)
<https://reviews.apache.org/r/64575/#comment272563>

    Please backtick class values.


- Alexander Rukletsov


On Dec. 13, 2017, 7:47 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64575/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2017, 7:47 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-7361
>     https://issues.apache.org/jira/browse/MESOS-7361
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This function always returns a ContainerClass, `DEFAULT` being the
> default value returned. Also simplifies the conditional statements
> in mesos/containerizer.cpp to use the function added.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.hpp 965e183bb5c54f31d90e910edd35313ab380cea9

>   src/slave/containerizer/mesos/containerizer.cpp 7ab0b07f689f872573ca458ae47cd6426ebc0365

> 
> 
> Diff: https://reviews.apache.org/r/64575/diff/2/
> 
> 
> Testing
> -------
> 
> ```
> GTEST_FILTER="" nice make check -j16 V=0
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message