mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 64623: Fixed a bug in handling standalone container recovery.
Date Fri, 15 Dec 2017 10:04:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64623/#review193894
-----------------------------------------------------------


Ship it!




Ship It!

- Gilbert Song


On Dec. 14, 2017, 12:14 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64623/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2017, 12:14 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-7302
>     https://issues.apache.org/jira/browse/MESOS-7302
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> It's possible that the pid is not known for a standalone container. For
> instance, the agent crashes after the containerizer checkpoints the
> runtime directory, but before it is able to checkpoint the pid. In that
> case, we just assume that the child will exit due to the broken control
> pipe and we can move to destroy without recovering it.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp 7ab0b07f689f872573ca458ae47cd6426ebc0365

> 
> 
> Diff: https://reviews.apache.org/r/64623/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message