mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 64353: Added example VolumeProfile module.
Date Fri, 15 Dec 2017 08:50:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64353/#review193892
-----------------------------------------------------------




src/resource_provider/uri_volume_profile.hpp
Lines 81 (patched)
<https://reviews.apache.org/r/64353/#comment272560>

    We cannot do this through `Flags` because the content of the file referred to by the URI
will be loaded: https://github.com/apache/mesos/blob/master/3rdparty/stout/include/stout/flags/fetch.hpp


- Chun-Hung Hsiao


On Dec. 9, 2017, 2:17 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64353/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2017, 2:17 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jie Yu.
> 
> 
> Bugs: MESOS-8251
>     https://issues.apache.org/jira/browse/MESOS-8251
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This example module shows how a VolumeProfile module might be
> implemented (and is a viable module in its own right).  The module
> can be configured to fetch a map of profiles from a URI (`file://` or
> `http(s)://`) and possibly cache this item for some time.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am f5a4edd245e8d6535502e951ecaa526c2bae25f9 
>   src/resource_provider/uri_volume_profile.hpp PRE-CREATION 
>   src/resource_provider/uri_volume_profile.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64353/diff/4/
> 
> 
> Testing
> -------
> 
> See end of chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message