mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 64630: Narrowed task sandbox permissions from 0755 to 0750.
Date Fri, 15 Dec 2017 02:43:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64630/#review193870
-----------------------------------------------------------



FAIL: Mesos tests failed to build.

Reviews applied: `['64630']`

Failed command: `cmake.exe --build . --target mesos-tests --config Debug`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64630

Relevant logs:

- [mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64630/logs/mesos-tests-build-cmake-stdout.log):

```
  D:\DCOS\mesos\mesos\src\master/master.hpp(2093): warning C4244: 'return': conversion from
'unsigned __int64' to 'double', possible loss of data (compiling source file D:\DCOS\mesos\mesos\src\tests\containerizer\cpu_isolator_tests.cpp)
[D:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  D:\DCOS\mesos\mesos\src\master/master.hpp(2093): warning C4244: 'return': conversion from
'unsigned __int64' to 'double', possible loss of data (compiling source file D:\DCOS\mesos\mesos\src\tests\containerizer\memory_isolator_tests.cpp)
[D:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  D:\DCOS\mesos\mesos\src\master/master.hpp(2093): warning C4244: 'return': conversion from
'unsigned __int64' to 'double', possible loss of data (compiling source file D:\DCOS\mesos\mesos\src\tests\containerizer\docker_tests.cpp)
[D:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  D:\DCOS\mesos\3rdparty\googletest-1.8.0\src\googletest-1.8.0\googletest\include\gtest/gtest-printers.h(875):
warning C4996: 'std::tr1': warning STL4002: The non-Standard std::tr1 namespace and TR1-only
machinery are deprecated and will be REMOVED. You can define _SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING
to acknowledge that you have received this warning. (compiling source file D:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp)
[D:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  D:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): warning C4244: 'argument':
conversion from 'ULONG_PTR' to 'pid_t', possible loss of data (compiling source file D:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp)
[D:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  D:\DCOS\mesos\3rdparty\googletest-1.8.0\src\googletest-1.8.0\googletest\include\gtest/gtest-printers.h(875):
warning C4996: 'std::tr1': warning STL4002: The non-Standard std::tr1 namespace and TR1-only
machinery are deprecated and will be REMOVED. You can define _SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING
to acknowledge that you have received this warning. (compiling source file D:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp)
[D:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  D:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): warning C4244: 'argument':
conversion from 'ULONG_PTR' to 'pid_t', possible loss of data (compiling source file D:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp)
[D:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  D:\DCOS\mesos\3rdparty\googletest-1.8.0\src\googletest-1.8.0\googletest\include\gtest/gtest-printers.h(875):
warning C4996: 'std::tr1': warning STL4002: The non-Standard std::tr1 namespace and TR1-only
machinery are deprecated and will be REMOVED. You can define _SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING
to acknowledge that you have received this warning. (compiling source file D:\DCOS\mesos\mesos\src\tests\containerizer\cpu_isolator_tests.cpp)
[D:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  D:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): warning C4244: 'argument':
conversion from 'ULONG_PTR' to 'pid_t', possible loss of data (compiling source file D:\DCOS\mesos\mesos\src\tests\containerizer\cpu_isolator_tests.cpp)
[D:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  D:\DCOS\mesos\3rdparty\googletest-1.8.0\src\googletest-1.8.0\googletest\include\gtest/gtest-printers.h(875):
warning C4996: 'std::tr1': warning STL4002: The non-Standard std::tr1 namespace and TR1-only
machinery are deprecated and will be REMOVED. You can define _SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING
to acknowledge that you have received this warning. (compiling source file D:\DCOS\mesos\mesos\src\tests\containerizer\memory_isolator_tests.cpp)
[D:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  D:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): warning C4244: 'argument':
conversion from 'ULONG_PTR' to 'pid_t', possible loss of data (compiling source file D:\DCOS\mesos\mesos\src\tests\containerizer\memory_isolator_tests.cpp)
[D:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  D:\DCOS\mesos\3rdparty\googletest-1.8.0\src\googletest-1.8.0\googletest\include\gtest/gtest-printers.h(875):
warning C4996: 'std::tr1': warning STL4002: The non-Standard std::tr1 namespace and TR1-only
machinery are deprecated and will be REMOVED. You can define _SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING
to acknowledge that you have received this warning. (compiling source file D:\DCOS\mesos\mesos\src\tests\containerizer\docker_tests.cpp)
[D:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  D:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): warning C4244: 'argument':
conversion from 'ULONG_PTR' to 'pid_t', possible loss of data (compiling source file D:\DCOS\mesos\mesos\src\tests\containerizer\docker_tests.cpp)
[D:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  D:\DCOS\mesos\3rdparty\googletest-1.8.0\src\googletest-1.8.0\googletest\include\gtest/gtest-printers.h(884):
warning C4996: 'std::tr1': warning STL4002: The non-Standard std::tr1 namespace and TR1-only
machinery are deprecated and will be REMOVED. You can define _SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING
to acknowledge that you have received this warning. (compiling source file D:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp)
[D:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  D:\DCOS\mesos\3rdparty\googletest-1.8.0\src\googletest-1.8.0\googletest\include\gtest/gtest-printers.h(884):
warning C4996: 'std::tr1': warning STL4002: The non-Standard std::tr1 namespace and TR1-only
machinery are deprecated and will be REMOVED. You can define _SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING
to acknowledge that you have received this warning. (compiling source file D:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp)
[D:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  D:\DCOS\mesos\3rdparty\googletest-1.8.0\src\googletest-1.8.0\googletest\include\gtest/gtest-printers.h(884):
warning C4996: 'std::tr1': warning STL4002: The non-Standard std::tr1 namespace and TR1-only
machinery are deprecated and will be REMOVED. You can define _SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING
to acknowledge that you have received this warning. (compiling source file D:\DCOS\mesos\mesos\src\tests\containerizer\cpu_isolator_tests.cpp)
[D:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  D:\DCOS\mesos\3rdparty\googletest-1.8.0\src\googletest-1.8.0\googletest\include\gtest/gtest-printers.h(884):
warning C4996: 'std::tr1': warning STL4002: The non-Standard std::tr1 namespace and TR1-only
machinery are deprecated and will be REMOVED. You can define _SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING
to acknowledge that you have received this warning. (compiling source file D:\DCOS\mesos\mesos\src\tests\containerizer\memory_isolator_tests.cpp)
[D:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  D:\DCOS\mesos\3rdparty\googletest-1.8.0\src\googletest-1.8.0\googletest\include\gtest/gtest-printers.h(884):
warning C4996: 'std::tr1': warning STL4002: The non-Standard std::tr1 namespace and TR1-only
machinery are deprecated and will be REMOVED. You can define _SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING
to acknowledge that you have received this warning. (compiling source file D:\DCOS\mesos\mesos\src\tests\containerizer\docker_tests.cpp)
[D:\DCOS\mesos\src\tests\mesos-tests.vcxproj]


"D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
(ClCompile target) -> 
  D:\DCOS\mesos\mesos\src\tests\api_tests.cpp(2327): error C2039: 'switch_user': is not a
member of 'mesos::internal::slave::Flags' [D:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  D:\DCOS\mesos\mesos\src\tests\slave_authorization_tests.cpp(98): error C2039: 'switch_user':
is not a member of 'mesos::internal::slave::Flags' [D:\DCOS\mesos\src\tests\mesos-tests.vcxproj]

    2148 Warning(s)
    2 Error(s)

Time Elapsed 00:21:46.52
```

- [mesos-tests-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64630/logs/mesos-tests-CMakeOutput.log):

```
  Creating directory "cmTC_59351.dir\Debug\".

  Creating directory "D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".

  Creating directory "cmTC_59351.dir\Debug\cmTC_59351.tlog\".

InitializeBuildStatus:

  Creating "cmTC_59351.dir\Debug\cmTC_59351.tlog\unsuccessfulbuild" because "AlwaysCreate"
was specified.

ClCompile:

  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\CL.exe
/c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11
/D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope
/Zc:inline /GR /Fo"cmTC_59351.dir\Debug\" /Fd"cmTC_59351.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue
D:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx

  Microsoft (R) C/C++ Optimizing Compiler Version 19.12.25830.2 for x64

  Copyright (C) Microsoft Corporation.  All rights reserved.

  

  cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11
/D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope
/Zc:inline /GR /Fo"cmTC_59351.dir\Debug\" /Fd"cmTC_59351.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue
D:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx

  src.cxx

  

Link:

  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\link.exe
/ERRORREPORT:QUEUE /OUT:"D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_59351.exe" /INCREMENTAL
/NOLOGO kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib
uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'"
/manifest:embed /DEBUG /PDB:"D:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_59351.pdb" /SUBSYSTEM:CONSOLE
/TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:"D:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_59351.lib"
/MACHINE:X64  /machine:x64 cmTC_59351.dir\Debug\src.obj

  cmTC_59351.vcxproj -> D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_59351.exe

FinalizeBuildStatus:

  Deleting file "cmTC_59351.dir\Debug\cmTC_59351.tlog\unsuccessfulbuild".

  Touching "cmTC_59351.dir\Debug\cmTC_59351.tlog\cmTC_59351.lastbuildstate".

Done Building Project "D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_59351.vcxproj" (default targets).



Build succeeded.

    0 Warning(s)

    0 Error(s)



Time Elapsed 00:00:00.99


Source file was:
int main() { return 0; }
```

- [mesos-tests-CMakeError.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64630/logs/mesos-tests-CMakeError.log):

```
PrepareForBuild:

  Creating directory "cmTC_fcb35.dir\Debug\".

  Creating directory "D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".

  Creating directory "cmTC_fcb35.dir\Debug\cmTC_fcb35.tlog\".

InitializeBuildStatus:

  Creating "cmTC_fcb35.dir\Debug\cmTC_fcb35.tlog\unsuccessfulbuild" because "AlwaysCreate"
was specified.

ClCompile:

  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\CL.exe
/c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE
/D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t
/Zc:forScope /Zc:inline /Fo"cmTC_fcb35.dir\Debug\" /Fd"cmTC_fcb35.dir\Debug\vc141.pdb" /Gd
/TC /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c

  Microsoft (R) C/C++ Optimizing Compiler Version 19.12.25830.2 for x64

  Copyright (C) Microsoft Corporation.  All rights reserved.

  

  cl /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D
_UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise
/Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_fcb35.dir\Debug\" /Fd"cmTC_fcb35.dir\Debug\vc141.pdb"
/Gd /TC /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c

  CheckIncludeFile.c

  

D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include
file: 'pthread.h': No such file or directory [D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_fcb35.vcxproj]

Done Building Project "D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_fcb35.vcxproj" (default targets)
-- FAILED.



Build FAILED.



"D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_fcb35.vcxproj" (default target) (1) ->

(ClCompile target) -> 

  D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open
include file: 'pthread.h': No such file or directory [D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_fcb35.vcxproj]



    0 Warning(s)

    1 Error(s)



Time Elapsed 00:00:00.82



```

- Mesos Reviewbot Windows


On Dec. 15, 2017, 12:10 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64630/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2017, 12:10 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Ilya Pronin, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-8332
>     https://issues.apache.org/jira/browse/MESOS-8332
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since task sandboxes can contain private data, we should not
> make them accessible to others by default. This changes all the
> places that create a task sandbox directory to use a helper API
> `slave::paths::createSandboxPath` that consistently deals with
> setting the directory mode and ownership.
> 
> A number of tests depended on the previous behavior where
> failing to change the ownership was logged but did not cause
> a failure. Depending on the test, these were updated to either
> disable the agent `switch_user` flag, or to specify the current
> user in the task launch message.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp 7ab0b07f689f872573ca458ae47cd6426ebc0365

>   src/slave/containerizer/mesos/paths.cpp 8a188a918873eef468a984b80f5ea7ebaa8fb923 
>   src/slave/http.cpp ed22b9f6bfa1c480a0672ce25d364bba6e33a200 
>   src/slave/paths.hpp 9cbacd8da62e7c7386dca7031fc09a46ae773161 
>   src/slave/paths.cpp fca2a0eec2a75ed76028ea54dc992502275d4bce 
>   src/tests/api_tests.cpp 86cbba4fab5e7a45298d17f3f2969391cc18be68 
>   src/tests/master_allocator_tests.cpp 9bca27c7612b9ac4813f794bcc9ed38aeed078e5 
>   src/tests/master_authorization_tests.cpp 676543a5ad1bb5d47011fc2a8b05dfaaeef18c64 
>   src/tests/slave_authorization_tests.cpp 4ba0b8e96614a2df0daec576c08fe02462ccaa27 
> 
> 
> Diff: https://reviews.apache.org/r/64630/diff/1/
> 
> 
> Testing
> -------
> 
> make check (Fedora 27)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message