mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gaston Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 64551: Integrated the status update manager into SLRP.
Date Thu, 14 Dec 2017 23:49:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64551/#review193857
-----------------------------------------------------------




src/resource_provider/storage/provider.cpp
Lines 1381 (patched)
<https://reviews.apache.org/r/64551/#comment272515>

    The RP doesn't know about this operation, so it wouldn't know how to recover it if checkpointed.
    
    That means that this line should be:
    
    `    statusUpdateManager.update(std::move(update), false)`


- Gaston Kleiman


On Dec. 13, 2017, 5:18 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64551/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2017, 5:18 p.m.)
> 
> 
> Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch uses the status update manager to send status updates and
> recover operations that are checkpointed as completed in the status
> update manager but still in the pending list in SLRP. It also forwards
> the acknowledgements to the status update manager, and garbage collect
> the metadata for offer operations.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/daemon.hpp 7c513a2b7c7ca958f9ea57326493f74df5b67c8f 
>   src/resource_provider/daemon.cpp 7c783e309672a2d93532fb17f13afcb96d5a7006 
>   src/resource_provider/local.hpp 46111d9f8969ea47e695d08832cb5a9ea60d1971 
>   src/resource_provider/local.cpp d1d683534d186e77a2beb32c978f2aaea289b086 
>   src/resource_provider/storage/provider.hpp 374f837ad693820afffb86bd1e54915f6796d088

>   src/resource_provider/storage/provider.cpp e806f44ef33405d4a2b133576c60be56e9fe3435

> 
> 
> Diff: https://reviews.apache.org/r/64551/diff/5/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message