mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ilya Pronin <ipro...@twopensource.com>
Subject Review Request 64626: Prototype: Added LIBPROCESS_LOCAL_MESSAGE_PASSING option.
Date Thu, 14 Dec 2017 22:27:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64626/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
-------

The new option allows to disable local message passing when messages are
sent between UPIDs in the same OS process. Enabled by default.


Diffs
-----

  3rdparty/libprocess/src/process.cpp 75cf1d3b6d3d257ba9bc81c68017a74a6511cebf 


Diff: https://reviews.apache.org/r/64626/diff/1/


Testing
-------

Ran `make check` and `make check LIBPROCESS_LOCAL_MESSAGE_PASSING=0` in libprocess.
Ran `make check` in Mesos. Disabled local message passing breaks Mesos tests that use the
replicated log, because it seemingly relies on "immediate" local message delivery (see [CoordinatorProcess::checkLearnPhase()](https://github.com/apache/mesos/blob/784b7f599f8ad8350fc7d6703a4b584301b23edc/src/log/coordinator.cpp#L396)).


Thanks,

Ilya Pronin


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message