mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 64506: Correctly reset slave status when aborting a registration.
Date Thu, 14 Dec 2017 15:32:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64506/
-----------------------------------------------------------

(Updated Dec. 14, 2017, 3:32 p.m.)


Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
-------

Previously, the slave was not erased from the `registering`
and `reregistering` sets in the master for some code paths
that would result in a failed (re-)registration attempt.

This could lead to a state where the reason of the unsuccessful
(re-)registration attempt is fixed on the agent, but the master
ignores subsequent attempts because it assumes the previous
operation is still in progress.


Diffs (updated)
-----

  src/master/master.cpp b3e074cfe86600793310deb87932fa145e95055d 
  src/tests/master_tests.cpp 7b087675200fe0ca69319b715997700a91d9f6b2 


Diff: https://reviews.apache.org/r/64506/diff/2/

Changes: https://reviews.apache.org/r/64506/diff/1-2/


Testing
-------

`make check`


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message