mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 64561: Removed resource categories in UpdateSlaveMessage.
Date Wed, 13 Dec 2017 19:34:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64561/
-----------------------------------------------------------

(Updated Dec. 13, 2017, 7:34 p.m.)


Review request for mesos, Benjamin Bannier and Jan Schlicht.


Changes
-------

addressed comments.


Repository: mesos


Description
-------

Given that now we use `UpdateSlaveMessage` to send resource provider
information directly, having resource categories in the message is
unnecessary and misleading.

Instead, this patch introduced a single optional boolean to indicate if
oversubscribed resources need to be updated or not.


Diffs (updated)
-----

  src/master/master.cpp 806fbc275af11bb37c2daa369f69a71bc4f36312 
  src/messages/messages.proto e680cd5e4d5a93c3c77309f327844f55fbb239a1 
  src/slave/slave.hpp 7c40fc71b49057fea0cfd85290931fbd0f6a9d62 
  src/slave/slave.cpp d997b4272578efffed05d38771f17df387ccac48 
  src/tests/oversubscription_tests.cpp 3f57ce105e24e9f9cd681d8d984dbe242aa51f75 


Diff: https://reviews.apache.org/r/64561/diff/2/

Changes: https://reviews.apache.org/r/64561/diff/1-2/


Testing
-------

make check


Thanks,

Jie Yu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message