mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 64475: Initialized offer operation status update manager in SLRP.
Date Wed, 13 Dec 2017 19:25:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64475/#review193722
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/paths.cpp
Lines 581-587 (patched)
<https://reviews.apache.org/r/64475/#comment272311>

    Can you use `basename` here to extract the uuid part?


- Jie Yu


On Dec. 13, 2017, 2:33 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64475/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2017, 2:33 a.m.)
> 
> 
> Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds an agent filesystem layout for checkpointing offer
> operation status updates for resource providers, and initialized
> a status update manager in storage local resource provider.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/provider.cpp e806f44ef33405d4a2b133576c60be56e9fe3435

>   src/slave/paths.hpp d645d871c36bbe8e766a98650f6aa23b6eab65d8 
>   src/slave/paths.cpp b8004e76964abc210820368a89dbfa6928ef7bfd 
> 
> 
> Diff: https://reviews.apache.org/r/64475/diff/4/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message