mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Review Request 64574: Ensured trailing '/' in URL is insignificant.
Date Wed, 13 Dec 2017 13:39:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64574/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier and Benjamin Mahler.


Bugs: MESOS-5333
    https://issues.apache.org/jira/browse/MESOS-5333


Repository: mesos


Description
-------

Prior to this patch, adding a trailing '/' to a valid URL path, e.g.,
"/state/", yielded a 404 response. This patch ensures that two URLs
which differ only in trailing '/' produce the same result.


Diffs
-----

  3rdparty/libprocess/src/process.cpp 75cf1d3b6d3d257ba9bc81c68017a74a6511cebf 
  3rdparty/libprocess/src/tests/http_tests.cpp 9daac715f0242921b7f9f5c20b3eb27f1be802d4 


Diff: https://reviews.apache.org/r/64574/diff/1/


Testing
-------

Ensured the modified test fails without the fix.
`make check` on Mac OS 10.11.6 and several Linux distributions.


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message