mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 64558: Added a missing check for parent container has config recovered.
Date Wed, 13 Dec 2017 06:32:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64558/#review193654
-----------------------------------------------------------




src/slave/containerizer/mesos/containerizer.cpp
Line 1723 (original), 1723 (patched)
<https://reviews.apache.org/r/64558/#comment272228>

    This check is not needed since the check above is necessary.


- Gilbert Song


On Dec. 12, 2017, 4:33 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64558/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2017, 4:33 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Greg Mann.
> 
> 
> Bugs: MESOS-8325
>     https://issues.apache.org/jira/browse/MESOS-8325
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a missing check for parent container has config recovered.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp a67311734a7cd8155ba54fe9ac45b7a0e3312168

> 
> 
> Diff: https://reviews.apache.org/r/64558/diff/1/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message