mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Re: Review Request 64386: Windows: Enabled docker health checks.
Date Wed, 13 Dec 2017 01:43:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64386/
-----------------------------------------------------------

(Updated Dec. 13, 2017, 1:43 a.m.)


Review request for mesos, Andrew Schwartzmeyer, Jie Yu, Joseph Wu, and Michael Park.


Changes
-------

Fixed field reordering warning.


Repository: mesos


Description (updated)
-------

The network health checks called curl and then executed setns to
enter to container network namespace, which did not work on Windows.
To do the equivalent, Windows nows calls docker run with powershell's
curl equivalent (Invoke-WebRequest) and uses the
network=container:<ID> flag to enter the container's namespace.


Diffs (updated)
-----

  src/checks/checker.hpp 93502270f31e80c5f7c94b5b456625e9cdea1837 
  src/checks/checker.cpp fff0aac504b4283a210f936e00c977fa60d88b3d 
  src/checks/checker_process.hpp 510f3b2e6e689faaf26595214ce377c2b5518f28 
  src/checks/checker_process.cpp 496bd41811a1984e905c851b5e990495517c17b8 
  src/checks/health_checker.hpp 019fbd791f250ecc28ff59d779f90e7ccbf0c685 
  src/checks/health_checker.cpp eaf9a18817eeeff7c29c7a4b9d1b183f398760a3 
  src/docker/executor.cpp 3974f20052e3c12eb154a5146d19d4dc1759859f 
  src/launcher/executor.cpp c688c04e598ac140421fd5e47359b0e48d30bcc5 


Diff: https://reviews.apache.org/r/64386/diff/2/

Changes: https://reviews.apache.org/r/64386/diff/1-2/


Testing (updated)
-------

See https://reviews.apache.org/r/64387/


Thanks,

Akash Gupta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message