mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 64461: Windows: Added legacy support for admin-only symlinks.
Date Tue, 12 Dec 2017 20:59:03 GMT


> On Dec. 8, 2017, 5:47 p.m., Akash Gupta wrote:
> > 3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp
> > Lines 364 (patched)
> > <https://reviews.apache.org/r/64461/diff/1/?file=1911723#file1911723line367>
> >
> >     Could you point out where in the docs that say this mutex is required. I couldn't
find it.
> 
> Andrew Schwartzmeyer wrote:
>     I don't honestly know. This came from resurrected code. It's about time to double
check its correctness.

As far as I've been able to find, this does not appear to be true.

You either have, as a user, the `SeCreateSymbolicLinkPrivilege` privilege, or you don't. If
you don't, the call fails with permission denied. If you do, the call succeeds. Nothing in
the current documentation says that it modifies the process's permissions in order to create
the link. It certainly doesn't appear to prompt like "you need to be an admin to do this,
continue?" and elevate then. It _seems_ to be all or nothing.

Nothing in the linked `CreateSymlink` documentation mentions this either. I'm getting tempted
to remove it entirely.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64461/#review193302
-----------------------------------------------------------


On Dec. 8, 2017, 1:18 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64461/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2017, 1:18 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Alexander Rukletsov, Greg Mann, and Joseph Wu.
> 
> 
> Bugs: MESOS-8307
>     https://issues.apache.org/jira/browse/MESOS-8307
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Some users are regrettably stuck on versions of Windows before this
> feature was added. If the `ALLOW_UNPRIVILEGED` flag is unsupported, the
> creation of the symlink will fail with `ERROR_INVALID_PARAMETER`. In
> this case, we try again without the flag (which will require
> administrative privileges, and so need to be guarded by a mutex) for
> these older systems.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 158f44550327c63fb416052ad9978b55e4efe36b

> 
> 
> Diff: https://reviews.apache.org/r/64461/diff/1/
> 
> 
> Testing
> -------
> 
> Still works on Windows 10 Fall Creator's Update, needs to be tested to prove working
on legacy systems.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message