mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gaston Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 64550: Made `update` return a future completed before `forwardCallback`.
Date Tue, 12 Dec 2017 19:19:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64550/#review193593
-----------------------------------------------------------


Fix it, then Ship it!




In the commit message: `s/This is useful if the caller of the status update manager want/This
is useful if
the caller of the status update manager wants/`


src/status_update_manager/status_update_manager_process.hpp
Lines 513 (patched)
<https://reviews.apache.org/r/64550/#comment272161>

    s/asynchoronus/asynchronous/
    
    I'd put this comment right above the `dispatch` call.


- Gaston Kleiman


On Dec. 12, 2017, 9:49 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64550/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2017, 9:49 a.m.)
> 
> 
> Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We maintain an ordering invariant that the completion of the future
> returned by `update` happens before the invocation of `forwardCallback`.
> This invariant provides the guarantee that if `forwardCallback` is
> deferred to the same context as the chained callback of the returned
> future, the latter will happen before the earlier. This is useful if
> the caller of the status update manager want to maintain its internal
> state after the manager checkpoints the status update but before the
> status update is sent out.
> 
> 
> Diffs
> -----
> 
>   src/status_update_manager/status_update_manager_process.hpp 1ac64410594134ce3e709d396d0a74a3d0aa2007

> 
> 
> Diff: https://reviews.apache.org/r/64550/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message