mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gaston Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 64475: Initialized offer operation status update manager in SLRP.
Date Tue, 12 Dec 2017 19:08:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64475/#review193587
-----------------------------------------------------------




src/resource_provider/storage/provider.cpp
Line 362 (original), 365 (patched)
<https://reviews.apache.org/r/64475/#comment272151>

    s/synchoronusly/synchronously/



src/resource_provider/storage/provider.cpp
Lines 2476-2477 (patched)
<https://reviews.apache.org/r/64475/#comment272154>

    This loses the error message returned by `slave::state::checkpoint()`.
    
    I think that the following would be make debugging easier:
    
    ```
      Try<Nothing> result = slave::state::checkpoint(
          statePath, volumes.at(volumeId).state);
    
      CHECK_SOME(result) << "Failed to checkpoint volume state to '" << statePath
                         << "': " << result.error();
    ```



src/resource_provider/storage/provider.cpp
Lines 2445-2447 (original), 2492-2494 (patched)
<https://reviews.apache.org/r/64475/#comment272157>

    ```
    // TODO(chhsiao): Maintain a list of terminated but unacknowledged
    // offer operations in memory and reconstruct it during recovery
    // by querying the status update manager.
    ```



src/resource_provider/storage/provider.cpp
Lines 2541-2543 (patched)
<https://reviews.apache.org/r/64475/#comment272159>

    Once the following patch is committed, `statusUpdate.has_latest_status()` will always
return `true`, so we don't the if statement: https://reviews.apache.org/r/64521/


- Gaston Kleiman


On Dec. 12, 2017, 9:51 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64475/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2017, 9:51 a.m.)
> 
> 
> Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds an agent filesystem layout for checkpointing offer
> operation status updates for resource providers, and initialized
> a status update manager in storage local resource provider.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/provider.cpp e806f44ef33405d4a2b133576c60be56e9fe3435

>   src/slave/paths.hpp d645d871c36bbe8e766a98650f6aa23b6eab65d8 
>   src/slave/paths.cpp b8004e76964abc210820368a89dbfa6928ef7bfd 
> 
> 
> Diff: https://reviews.apache.org/r/64475/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message