mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Review Request 64536: Removed race from SlaveRecoveryTest.ReconnectExecutor.
Date Tue, 12 Dec 2017 12:00:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64536/
-----------------------------------------------------------

Review request for mesos and Alexander Rukletsov.


Repository: mesos


Description
-------

Since the executor now sends two status updates in potentially
rapid progression, there was a race where the slave successfully
received a TASK_RUNNING update before shutting down, throwing off
the later checks.


Diffs
-----

  src/tests/slave_recovery_tests.cpp 253b0fc2ff7ec1f00937d42636151553c46d5175 


Diff: https://reviews.apache.org/r/64536/diff/1/


Testing
-------

`./mesos-tests --gtest_filter="SlaveRecoveryTest/0.ReconnectExecutor" --gtest_repeat=500 --gtest_break_on_failure`


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message