mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 64505: Made the agent check for offer operation update retries.
Date Tue, 12 Dec 2017 01:08:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64505/#review193476
-----------------------------------------------------------




src/slave/slave.cpp
Lines 7296-7298 (patched)
<https://reviews.apache.org/r/64505/#comment272033>

    Wondering if we should do this check in `updateOfferOperation`?
    
    What's the equality check for `OfferOperationStatus`? does the order in `Resources` matter?
    
    Also, wondering what we do for Tasks in this situation?


- Jie Yu


On Dec. 11, 2017, 8:17 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64505/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2017, 8:17 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Local resource providers send all offer operation status updates
> using the reosurce provider API. This patch makes the agent's
> resource provider message handler skip operation updates when an
> update is a retry.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 373e393ca1e7c0c30c3474cc9e630e25ad92f235 
> 
> 
> Diff: https://reviews.apache.org/r/64505/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message