mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Re: Review Request 64434: Windows: Fixed `os::stat::size()`.
Date Mon, 11 Dec 2017 20:58:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64434/#review193445
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/stout/include/stout/os/windows/stat.hpp
Line 123 (original), 112 (patched)
<https://reviews.apache.org/r/64434/#comment271988>

    small nit but does `handle->get_handle()` work? It looks cleaner to me.


- Akash Gupta


On Dec. 8, 2017, 1:05 a.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64434/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2017, 1:05 a.m.)
> 
> 
> Review request for mesos, Akash Gupta and Joseph Wu.
> 
> 
> Bugs: MESOS-5939
>     https://issues.apache.org/jira/browse/MESOS-5939
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed the use of CRT runtime API `::_stat`, and instead implemented
> with `get_handle_[no_]follow()` plus `GetFileSizeEx` to correctly obtain
> the size of a file with long-path and symlink-aware semantics.
> 
> This resolves MESOS-5939 and so enables `OsTest.SYMLINK_Size`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/windows/stat.hpp 2ba6969a78eb6ed7007a3d404d5179b143790480

>   3rdparty/stout/tests/os_tests.cpp 93a23a800e5301abdc71c8b61022cc9baabf12c2 
> 
> 
> Diff: https://reviews.apache.org/r/64434/diff/2/
> 
> 
> Testing
> -------
> 
> [==========] Running 7 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 7 tests from OsTest
> [ RUN      ] OsTest.TrivialEnvironment
> [       OK ] OsTest.TrivialEnvironment (5 ms)
> [ RUN      ] OsTest.Argv
> [       OK ] OsTest.Argv (1 ms)
> [ RUN      ] OsTest.System
> 'invalid.command' is not recognized as an internal or external command,
> operable program or batch file.
> [       OK ] OsTest.System (277 ms)
> [ RUN      ] OsTest.SYMLINK_Size
> [       OK ] OsTest.SYMLINK_Size (7 ms)
> [ RUN      ] OsTest.BootId
> [       OK ] OsTest.BootId (4 ms)
> [ RUN      ] OsTest.TrivialUser
> [       OK ] OsTest.TrivialUser (4 ms)
> [ RUN      ] OsTest.SYMLINK_Realpath
> [       OK ] OsTest.SYMLINK_Realpath (7 ms)
> [----------] 7 tests from OsTest (318 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 7 tests from 1 test case ran. (321 ms total)
> [  PASSED  ] 7 tests.
> 
>   YOU HAVE 3 DISABLED TESTS
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message