mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 64439: Added `LocalResourceProviderDaemon` methods to modify configs.
Date Mon, 11 Dec 2017 20:27:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64439/#review193437
-----------------------------------------------------------


Fix it, then Ship it!





src/resource_provider/daemon.cpp
Lines 194 (patched)
<https://reviews.apache.org/r/64439/#comment271981>

    Why you need this given it's uuid already?


- Jie Yu


On Dec. 11, 2017, 3:56 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64439/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2017, 3:56 a.m.)
> 
> 
> Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-8244
>     https://issues.apache.org/jira/browse/MESOS-8244
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `add()` and `update()` methods adds a new config file and updates an
> existing config file of a local resource provider respectively. It will
> then trigger a rolead on the resource provider asynchronously.
> 
> The `remove()` method removes the config file, and triggers the resource
> provider to terminate asynchronously.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/daemon.cpp 61599828e1bb32b69e657cca90a535af3ec0c4dd 
> 
> 
> Diff: https://reviews.apache.org/r/64439/diff/4/
> 
> 
> Testing
> -------
> 
> See later in the chain.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message