mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 64434: Windows: Fixed `os::stat::size()`.
Date Mon, 11 Dec 2017 17:58:57 GMT


> On Dec. 11, 2017, 6:42 a.m., Mesos Reviewbot Windows wrote:
> > FAIL: Some Mesos tests failed.
> > 
> > Reviews applied: `['64434']`
> > 
> > Failed command: `D:\DCOS\mesos\src\mesos-tests.exe --verbose`
> > 
> > All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64434
> > 
> > Relevant logs:
> > 
> > - [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64434/logs/mesos-tests-stdout.log):
> > 
> > ```
> > 
> > [----------] 1 test from IsolationFlag/CpuIsolatorTest
> > [ RUN      ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
> > [       OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2327 ms)
> > [----------] 1 test from IsolationFlag/CpuIsolatorTest (2349 ms total)
> > 
> > [----------] 1 test from IsolationFlag/MemoryIsolatorTest
> > [ RUN      ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
> > [       OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2361 ms)
> > [----------] 1 test from IsolationFlag/MemoryIsolatorTest (2383 ms total)
> > 
> > [----------] Global test environment tear-down
> > [==========] 825 tests from 84 test cases ran. (309914 ms total)
> > [  PASSED  ] 815 tests.
> > [  FAILED  ] 10 tests, listed below:
> > [  FAILED  ] OfferOperationStatusUpdateManagerTest.UpdateAndAckNonTerminalUpdate
> > [  FAILED  ] OfferOperationStatusUpdateManagerTest.RecoverCheckpointedStream
> > [  FAILED  ] OfferOperationStatusUpdateManagerTest.RecoverEmptyFile
> > [  FAILED  ] OfferOperationStatusUpdateManagerTest.RecoverTerminatedStream
> > [  FAILED  ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdate
> > [  FAILED  ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdateAfterRecover
> > [  FAILED  ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAck
> > [  FAILED  ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAckAfterRecover
> > [  FAILED  ] OfferOperationStatusUpdateManagerTest.NonStrictRecoveryCorruptedFile
> > [  FAILED  ] SlaveTest.ResourceProviderPublishAll
> > 
> > 10 FAILED TESTS
> >   YOU HAVE 204 DISABLED TESTS
> > 
> > ```
> > 
> > - [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64434/logs/mesos-tests-stderr.log):
> > 
> > ```
> > I1211 14:42:21.074806  7604 master.cpp:10105] Updating the state of task f20ff420-5f34-41c3-b52c-5985a7a4d0e1
of framework 9a148041-eb93-42ed-a645-9ff264acd9ff-0000 (latest state: TASK_KILLED, status
update state: TASK_KILLED)
> > I1211 14:42:21.074806  8932 slave.cpp:3400] Shutting down framework 9a148041-eb93-42ed-a645-9ff264acd9ff-0000
> > I1211 14:42:21.075808  8932 slave.cpp:6091] Shutting dowI1211 14:42:20.391834  8172
exec.cpp:162] Version: 1.5.0
> > I1211 14:42:20.420815  6664 exec.cpp:237] Executor registered on agent 9a148041-eb93-42ed-a645-9ff264acd9ff-S0
> > I1211 14:42:20.423815  6764 executor.cpp:171] Received SUBSCRIBED event
> > I1211 14:42:20.428818  6764 executor.cpp:175] Subscribed executor on build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
> > I1211 14:42:20.428818  6764 executor.cpp:171] Received LAUNCH event
> > I1211 14:42:20.432839  6764 executor.cpp:637] Starting task f20ff420-5f34-41c3-b52c-5985a7a4d0e1
> > I1211 14:42:20.505832  6764 executor.cpp:477] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe
launch <POSSIBLY-SENSITIVE-DATA>'
> > I1211 14:42:21.048830  6764 executor.cpp:650] Forked command at 7784
> > I1211 14:42:21.077806  7280 exec.cpp:435] Executor asked to shutdown
> > I1211 14:42:21.077806  6764 executor.cpp:171] Received SHUTDOWN event
> > I1211 14:42:21.077806  6764 executor.cpp:747] Shutting down
> > I1211 14:42:21.077806  6764 executor.cpp:854] Sending SIGTERM to process tree at
pid 7n executor 'f20ff420-5f34-41c3-b52c-5985a7a4d0e1' of framework 9a148041-eb93-42ed-a645-9ff264acd9ff-0000
at executor(1)@10.3.1.5:57749
> > I1211 14:42:21.076805  7604 master.cpp:10211] Removing task f20ff420-5f34-41c3-b52c-5985a7a4d0e1
with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated:
*):[31000-32000] of framework 9a148041-eb93-42ed-a645-9ff264acd9ff-0000 on agent 9a148041-eb93-42ed-a645-9ff264acd9ff-S0
at slave(326)@10.3.1.5:57728 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
> > I1211 14:42:21.076805  8932 slave.cpp:909] Agent terminating
> > W1211 14:42:21.076805  8932 slave.cpp:3396] Ignoring shutdown framework 9a148041-eb93-42ed-a645-9ff264acd9ff-0000
because it is terminating
> > I1211 14:42:21.078806  7604 master.cpp:1310] Agent 9a148041-eb93-42ed-a645-9ff264acd9ff-S0
at slave(326)@10.3.1.5:57728 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
disconnected
> > I1211 14:42:21.078806  7604 master.cpp:3369] Disconnecting agent 9a148041-eb93-42ed-a645-9ff264acd9ff-S0
at slave(326)@10.3.1.5:57728 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
> > I1211 14:42:21.079820  7604 master.cpp:3388] Deactivating agent 9a148041-eb93-42ed-a645-9ff264acd9ff-S0
at slave(326)@10.3.1.5:57728 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
> > I1211 14:42:21.079820  6904 containerizer.cpp:2328] Destroying container c021fbf0-82ff-4e33-912a-03a1eb6711d9
in RUNNING state
> > I1211 14:42:21.079820  6904 containerizer.cpp:2930] Transitioning the state of container
c021fbf0-82ff-4e33-912a-03a1eb6711d9 from RUNNING to DESTROYING
> > I1211 14:42:21.080806  6904 launcher.cpp:156] Asked to destroy container c021fbf0-82ff-4e33-912a-03a1eb6711d9
> > I1211 14:42:21.080806  7404 hierarchical.cpp:344] Removed framework 9a148041-eb93-42ed-a645-9ff264acd9ff-0000
> > I1211 14:42:21.081806  7404 hierarchical.cpp:762] Agent 9a148041-eb93-42ed-a645-9ff264acd9ff-S0
deactivated
> > I1211 14:42:21.167871  6904 containerizer.cpp:2779] Container c021fbf0-82ff-4e33-912a-03a1eb6711d9
has exited
> > I1211 14:42:21.196346  5784 master.cpp:1152] Master terminating
> > I1211 14:42:21.198346  8068 hierarchical.cpp:605] Removed agent 9a148041-eb93-42ed-a645-9ff264acd9ff-S0
> > I1211 14:42:21.522279  1376 process.cpp:887] Failed to accept socket: future discarded
> > ```

These are known failures.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64434/#review193394
-----------------------------------------------------------


On Dec. 7, 2017, 5:05 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64434/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2017, 5:05 p.m.)
> 
> 
> Review request for mesos, Akash Gupta and Joseph Wu.
> 
> 
> Bugs: MESOS-5939
>     https://issues.apache.org/jira/browse/MESOS-5939
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed the use of CRT runtime API `::_stat`, and instead implemented
> with `get_handle_[no_]follow()` plus `GetFileSizeEx` to correctly obtain
> the size of a file with long-path and symlink-aware semantics.
> 
> This resolves MESOS-5939 and so enables `OsTest.SYMLINK_Size`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/windows/stat.hpp 2ba6969a78eb6ed7007a3d404d5179b143790480

>   3rdparty/stout/tests/os_tests.cpp 93a23a800e5301abdc71c8b61022cc9baabf12c2 
> 
> 
> Diff: https://reviews.apache.org/r/64434/diff/2/
> 
> 
> Testing
> -------
> 
> [==========] Running 7 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 7 tests from OsTest
> [ RUN      ] OsTest.TrivialEnvironment
> [       OK ] OsTest.TrivialEnvironment (5 ms)
> [ RUN      ] OsTest.Argv
> [       OK ] OsTest.Argv (1 ms)
> [ RUN      ] OsTest.System
> 'invalid.command' is not recognized as an internal or external command,
> operable program or batch file.
> [       OK ] OsTest.System (277 ms)
> [ RUN      ] OsTest.SYMLINK_Size
> [       OK ] OsTest.SYMLINK_Size (7 ms)
> [ RUN      ] OsTest.BootId
> [       OK ] OsTest.BootId (4 ms)
> [ RUN      ] OsTest.TrivialUser
> [       OK ] OsTest.TrivialUser (4 ms)
> [ RUN      ] OsTest.SYMLINK_Realpath
> [       OK ] OsTest.SYMLINK_Realpath (7 ms)
> [----------] 7 tests from OsTest (318 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 7 tests from 1 test case ran. (321 ms total)
> [  PASSED  ] 7 tests.
> 
>   YOU HAVE 3 DISABLED TESTS
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message