mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 64473: Fixed naming of a variable in `status_update_manager_process.hpp`.
Date Mon, 11 Dec 2017 16:38:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64473/#review193402
-----------------------------------------------------------


Ship it!




Ship It!

- Greg Mann


On Dec. 9, 2017, 12:25 a.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64473/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2017, 12:25 a.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Rename the variable `_update` to `update_` to make the name consistent
> with the style guide.
> 
> 
> Diffs
> -----
> 
>   src/status_update_manager/status_update_manager_process.hpp 1ac64410594134ce3e709d396d0a74a3d0aa2007

> 
> 
> Diff: https://reviews.apache.org/r/64473/diff/1/
> 
> 
> Testing
> -------
> 
> `GLOG_v=1 bin/mesos-tests.sh --gtest_filter="*OfferOperationStatusUpdateManagerTest*"
--verbose` passes on GNU/Linux.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message