mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 64381: Mesos: Used a namespace for UUID.
Date Mon, 11 Dec 2017 16:10:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64381/#review193399
-----------------------------------------------------------


Ship it!




- Benjamin Bannier


On Dec. 8, 2017, 4:14 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64381/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2017, 4:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-8309
>     https://issues.apache.org/jira/browse/MESOS-8309
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> To avoid conflicts when introducing a UUID type in Mesos' namespace,
> Stout's UUID type is put in the 'id' namespace.
> 
> 
> Diffs
> -----
> 
>   include/mesos/state/in_memory.hpp 203274242854d482b01275597b249c58e6dfe2ad 
>   include/mesos/state/leveldb.hpp 6c732d38d68a3d60d28ce68a6340e8771d849c53 
>   include/mesos/state/log.hpp ac0312fdb92c46bfa2a7b83e95e04fd1eaf87d03 
>   include/mesos/state/state.hpp 8f7f3ad0bda029e03d9bdb874cb26add3f888522 
>   include/mesos/state/storage.hpp 2bfa0478b0edf76d592cc9644da83d15a00bc68c 
>   include/mesos/state/zookeeper.hpp 8d8c19ce778f2499d86eb84008a61f211c528a3a 
>   src/checks/checker_process.cpp 496bd41811a1984e905c851b5e990495517c17b8 
>   src/common/protobuf_utils.hpp 03b7cafb264b07a5a27dbd8d5c074e96ce576ea0 
>   src/common/protobuf_utils.cpp c5504a00a7a84b824743f00c6b97ea299ac66eb4 
>   src/examples/long_lived_executor.cpp 319db93eff8fcd347b03a17f78f5e9b6ea01e7d3 
>   src/examples/persistent_volume_framework.cpp 9ccc7ebe3079823042a8e93313d378b7f892249b

>   src/examples/test_http_executor.cpp 2166faf576980b58a00c53f9a889bfaeddefdd29 
>   src/exec/exec.cpp cdbf149a9047ddad6beef64be1266e15e7643afc 
>   src/executor/executor.cpp 7280951909b677e2a7b0afbcddba4a299dbe6f06 
>   src/launcher/default_executor.cpp 248c46dbda3f63d8087f75120866c72e43aa4ed6 
>   src/launcher/executor.cpp c688c04e598ac140421fd5e47359b0e48d30bcc5 
>   src/master/http.cpp bb040ced65495cfe78b67ca7258499c16ac5d8a1 
>   src/master/master.hpp 1f5daae6abbf81cd5fc0341f5ee6c9678beb0d64 
>   src/master/master.cpp 5cba50636a9351d29660c54fad7734fcfea547b9 
>   src/master/validation.cpp 38d9a3c4204cfd6c93dde9216325db4d00cd5364 
>   src/messages/messages.cpp 56876f2d5a92237ccb85ec6d8ab8eb872061a7b5 
>   src/resource_provider/http_connection.hpp 47686a8025c34b61c9d6f69eb20a0917f0635776

>   src/resource_provider/manager.cpp f98611c351f11b15281dd3ef673ef80db1c44f07 
>   src/resource_provider/message.hpp bbf6bb2a0a4aa901ac038cdbe4dd46acc0f2e453 
>   src/sched/sched.cpp 72bd4138c6706d09c9c88a580f560dbdedf94574 
>   src/scheduler/scheduler.cpp e35470933f9f4d3c795d4630bf64db7fc8808ce9 
>   src/slave/containerizer/docker.cpp 229891da1b23ca1a5cf2b6b15cd16de6fa0d8240 
>   src/slave/containerizer/mesos/io/switchboard.cpp 8a00e6d47fe3d5415ca9202d6f37441fb6f12be7

>   src/slave/containerizer/mesos/isolators/volume/secret.cpp ba23519f7326d8ac1397d5c521efcb726914f7ea

>   src/slave/containerizer/mesos/provisioner/provisioner.cpp a17774449155aea1997a717230990ff93f7261f7

>   src/slave/slave.hpp 5cb0d55970e50c5b8b5ef9c43f2967f4663a7781 
>   src/slave/slave.cpp 54d8bcc035227dd6896ffa6e692a91749c0b56a6 
>   src/slave/state.hpp 8d088d02b786e1d4bf0187f4a574a0222811d10c 
>   src/slave/state.cpp 3396157d2a5917e6128030e84295f5862d544d98 
>   src/slave/task_status_update_manager.hpp 6bdb468908bd5d9763bccdbc1a5667a530527ea3 
>   src/slave/task_status_update_manager.cpp 1ec6be73043a81dcf00c522ccc80bb656af13026 
>   src/slave/validation.cpp 4a3a78a9c95bc421e55391ef3ee1172d37f2eac3 
>   src/state/in_memory.cpp 2539b4f57223514bcacd6c62bb01ef3a6f24aa73 
>   src/state/leveldb.cpp 9ced03a4a9f59fd949fc0735b2efcc6711dcfd1a 
>   src/state/log.cpp b71383906cf28fe0769cbb620387a0e0134f01f9 
>   src/state/zookeeper.cpp 1abd81651d575558f18001de89e9abef3a80caf4 
>   src/status_update_manager/offer_operation.hpp 8751f0b7b6471cab2db55bf52f45c2798e3ef192

>   src/status_update_manager/offer_operation.cpp f66690eadc0d7b16cc7de1b518904db2cab7ef82

>   src/status_update_manager/status_update_manager_process.hpp 1ac64410594134ce3e709d396d0a74a3d0aa2007

>   src/tests/agent_container_api_tests.cpp 595ce510783b6cdf219eadd287c57bd576d6443b 
>   src/tests/api_tests.cpp 3372849cb2aa070df6b2262b57baa0fab628e11d 
>   src/tests/container_daemon_tests.cpp 6e5efc952edeab0a03b33dcff81fec484126d068 
>   src/tests/containerizer/composing_containerizer_tests.cpp 1eab05ce488cf94afc2f5a6c2308e5c8db6f28b6

>   src/tests/containerizer/docker_containerizer_tests.cpp 1f6ff52daf9687621d42173b7bbf20b6b04e8ab9

>   src/tests/containerizer/io_switchboard_tests.cpp fe9643a8fea9963ac476e52697f03e5ac3ead2bf

>   src/tests/containerizer/isolator_tests.cpp b341a86bfbc36a2b7b723236cafddaec10ee0ee6

>   src/tests/containerizer/linux_filesystem_isolator_tests.cpp 4d796a8d46d667593f368daacadddaa5a292c907

>   src/tests/containerizer/mesos_containerizer_tests.cpp 98adcfcfba4e5ee975b7ed0c073758ec2726763d

>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp bb2abbc09e8a560830fb9da5c5da8e0bd80c6bc5

>   src/tests/containerizer/port_mapping_tests.cpp 38db7e5f05fb706f6e927d68362e8334ed6e85d5

>   src/tests/containerizer/provisioner_appc_tests.cpp fc1335c0d432e83c1d13a408aca79bd61ac49701

>   src/tests/containerizer/provisioner_docker_tests.cpp 2fe8950ad41d0018045c9581d5eb1757f40dec20

>   src/tests/containerizer/runtime_isolator_tests.cpp 089605d9b0708cb35c171bad2c141c70336c07bd

>   src/tests/containerizer/volume_host_path_isolator_tests.cpp 271bbbe71f16388d1331a9db120ba71b86cefa5f

>   src/tests/containerizer/volume_image_isolator_tests.cpp da3642233b49a21cd0c9d099acad94e4d62cad62

>   src/tests/containerizer/volume_sandbox_path_isolator_tests.cpp 5b75852d058687bf49e36bbdf50b61f7af1c1a77

>   src/tests/containerizer/volume_secret_isolator_tests.cpp 4d03a0232e2450a945afdd517009a8f377d394e5

>   src/tests/fault_tolerance_tests.cpp 6f69b6fca6980e13de456b62c17be1ec3fdf7672 
>   src/tests/fetcher_tests.cpp df9d2d9586a6457004506c4e2a972ccfc912c7c5 
>   src/tests/master_tests.cpp 7b087675200fe0ca69319b715997700a91d9f6b2 
>   src/tests/master_validation_tests.cpp 48c69a5c4d28a261fa4ac96f09e30fb66a7cff78 
>   src/tests/mesos.hpp 95068895da1f7267d4b326c636f29a3a68177105 
>   src/tests/mesos.cpp 7ed08a5ac2a0efdbd2a93fb48a70a23d0973dc51 
>   src/tests/offer_operation_status_update_manager_tests.cpp a31a525e1ee05492861885f59123471bc4ef33c6

>   src/tests/partition_tests.cpp 54ccf783682e7e6db0847b9a6313489b7f8181f8 
>   src/tests/paths_tests.cpp 07e0cacffc9d83c82ba5cea79d3f27e237bb4020 
>   src/tests/reconciliation_tests.cpp f88b115aba984ea700e2894039306355beb8e9cd 
>   src/tests/registrar_tests.cpp f93129f9b4e3194856044bb98ec7c0ded98c6626 
>   src/tests/resource_provider_manager_tests.cpp a6eb4c9a303780029244e069bdf550a8cd9c7bb4

>   src/tests/resource_provider_validation_tests.cpp bf789a05771b7c25f2fc2a8a5b35d38519e4793b

>   src/tests/scheduler_event_call_tests.cpp 48649f25e55c29644b6f7599207a7b09f57d94f6 
>   src/tests/scheduler_http_api_tests.cpp 67782edc12906192c827c12f7ae1f46d3fe485ac 
>   src/tests/slave_authorization_tests.cpp b7e8d3d6ce28c57a940a39f957d6808076c880e7 
>   src/tests/slave_recovery_tests.cpp 253b0fc2ff7ec1f00937d42636151553c46d5175 
>   src/tests/slave_tests.cpp 07145432c35c85a755b66ba575c2a46db072ce5c 
>   src/tests/slave_validation_tests.cpp e81b65bb67954e14eb82d8b80ffa679c2f9515fb 
>   src/tests/task_status_update_manager_tests.cpp d180e8c485591c787efa3e4a30fd8b1b113019bd

> 
> 
> Diff: https://reviews.apache.org/r/64381/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message