mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 64487: Passed the message directly to the Master::registerSlave handler.
Date Mon, 11 Dec 2017 12:42:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64487/#review193385
-----------------------------------------------------------


Fix it, then Ship it!




Let's adjust all handlers in a separate fix, and in this one only move from unpacked data
to messages in the agent registration handlers.


src/master/master.hpp
Lines 588 (patched)
<https://reviews.apache.org/r/64487/#comment271946>

    Let's just pass a `const` ref here, and instead adjust all handlers in a separate patch.


- Benjamin Bannier


On Dec. 10, 2017, 6:12 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64487/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2017, 6:12 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Some fields in `RegisterSlaveMessage` will become optional. This patch
> prepares for that. Also, by passing a message directly to the handler,
> it allows us to eliminate some copying by using rvalue references.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 5c26f2066aae31223ffdd76ed058d5a4e63a2603 
>   src/master/master.cpp b3e074cfe86600793310deb87932fa145e95055d 
>   src/master/validation.hpp 30db3bf3af9bec4d491d8102b079f7a26b45c2b5 
>   src/master/validation.cpp 38d9a3c4204cfd6c93dde9216325db4d00cd5364 
> 
> 
> Diff: https://reviews.apache.org/r/64487/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message