mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 64439: Added `LocalResourceProviderDaemon` methods to modify configs.
Date Mon, 11 Dec 2017 03:56:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64439/
-----------------------------------------------------------

(Updated Dec. 11, 2017, 3:56 a.m.)


Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.


Changes
-------

Addressed Jie's comments.


Bugs: MESOS-8244
    https://issues.apache.org/jira/browse/MESOS-8244


Repository: mesos


Description
-------

The `add()` and `update()` methods adds a new config file and updates an
existing config file of a local resource provider respectively. It will
then trigger a rolead on the resource provider asynchronously.

The `remove()` method removes the config file, and triggers the resource
provider to terminate asynchronously.


Diffs (updated)
-----

  src/resource_provider/daemon.cpp 61599828e1bb32b69e657cca90a535af3ec0c4dd 


Diff: https://reviews.apache.org/r/64439/diff/4/

Changes: https://reviews.apache.org/r/64439/diff/3-4/


Testing
-------

See later in the chain.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message