mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 64468: SLRP reconciliation only preserves missing resources that are converted.
Date Sat, 09 Dec 2017 02:11:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64468/#review193310
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Dec. 8, 2017, 9:59 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64468/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2017, 9:59 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When SLRP's checkpointed total resources is inconsistent with CSI
> plugin's reported resources, we still want to keep the missing resources
> that have been converted through an offer operation before, such that
> we can have an consistent view with the frameworks consuming the
> resource offers. It is safe to remove unconverted missing resources from
> SLRP's checkpointed total.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/provider.cpp 2193866e83850a04a3dc8231ab07e6104485f2b6

> 
> 
> Diff: https://reviews.apache.org/r/64468/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message