-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60620/#review193289
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Schwartzmeyer
On Dec. 7, 2017, 6:40 p.m., Jeff Coffler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60620/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2017, 6:40 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, Li Li, and Michael
Park.
>
>
> Bugs: MESOS-6705
> https://issues.apache.org/jira/browse/MESOS-6705
>
>
> Repository: mesos
>
>
> Description
> -------
>
> By default, ::write operations on Windows will include a \r\n (CR/LF)
> at the end of each line, which is not compatible with Linux. Mesos
> expects only \n (LF) characters between lines.
>
> This commit will modify Windows behavior to only include \n at the
> end of each line written to a text file.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/write.hpp 9ff749f209e6dd6ca3695907108a029c9a2b4f05
>
>
> Diff: https://reviews.apache.org/r/60620/diff/8/
>
>
> Testing
> -------
>
> Built successfully on both Linux (with autotools and cmake) and Windows (with cmake).
>
> Ran stout-tests and mesos-tests successfully on both Windows and Linux.
>
>
> Thanks,
>
> Jeff Coffler
>
>
|