-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64456/#review193263
-----------------------------------------------------------
Ship it!
Looks good, but please amend the commit message to explain why you opted to keep the long
wait time for both status updates.
- Benno Evers
On Dec. 8, 2017, 4:50 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64456/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2017, 4:50 p.m.)
>
>
> Review request for mesos and Benno Evers.
>
>
> Bugs: MESOS-8316
> https://issues.apache.org/jira/browse/MESOS-8316
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If a test launches a task that requires internet access, for example,
> to download docker images, an initial status update might take some
> time to arrive. To avoid flaky tests, we compensate for this by
> increasing the wait timeout via `AWAIT_READY_FOR`. However, with the
> introduction of `TASK_STARTING`, the first received message is not
> `TASK_RUNNING` any more, hence we should use `AWAIT_READY_FOR` for
> `TASK_STARTING` updates as well.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cgroups_isolator_tests.cpp 54404ee2a8e99128f57a95e56c7f2cb5dd37dbad
> src/tests/containerizer/cni_isolator_tests.cpp a6b660de63f767ff0ddc34791540de1427206e92
> src/tests/containerizer/docker_containerizer_tests.cpp 1f6ff52daf9687621d42173b7bbf20b6b04e8ab9
> src/tests/containerizer/memory_pressure_tests.cpp 9ada46d39f4cb4529298e0e9d2496ccd0522b3c6
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp bb2abbc09e8a560830fb9da5c5da8e0bd80c6bc5
> src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 5e40a940770cb45c9ac181b953a4e57e4b053445
> src/tests/containerizer/provisioner_appc_tests.cpp fc1335c0d432e83c1d13a408aca79bd61ac49701
> src/tests/containerizer/provisioner_docker_tests.cpp 2fe8950ad41d0018045c9581d5eb1757f40dec20
> src/tests/containerizer/runtime_isolator_tests.cpp 089605d9b0708cb35c171bad2c141c70336c07bd
> src/tests/default_executor_tests.cpp d3e3ef770656a36f3469f2ec655102a05adcae8a
> src/tests/health_check_tests.cpp c716ad9fa41fe9429de971bb2a1f2e790499572a
>
>
> Diff: https://reviews.apache.org/r/64456/diff/1/
>
>
> Testing
> -------
>
> make check on Mac OS 10.11.6 and various Linux distributions.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
|