mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 64430: Only passed agent's resource version in top-level 'UpdateSlaveMessage'.
Date Fri, 08 Dec 2017 11:33:03 GMT


> On Dec. 8, 2017, 6:15 a.m., Jie Yu wrote:
> > Let's also follow up with the change to remove `ResourcesCategory`

I posted https://reviews.apache.org/r/64445/ to address this in isolation and on top of the
changes here.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64430/#review193219
-----------------------------------------------------------


On Dec. 8, 2017, 12:32 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64430/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2017, 12:32 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Bugs: MESOS-8312
>     https://issues.apache.org/jira/browse/MESOS-8312
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since we have moved all resource provider-related information like
> e.g., resource versions to an explicit field in 'UpdateSlaveMessage',
> we now only pass agent information in top-level fields.
> 
> To model that we changed the top-level resource versions there from a
> repeated field to a single optional field. This will allow us to in
> the future pass agent information in the resource provider data
> structure as well.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 5cba50636a9351d29660c54fad7734fcfea547b9 
>   src/messages/messages.proto f71178438660fa16aad8f290391baba7813fbff0 
>   src/slave/slave.cpp 54d8bcc035227dd6896ffa6e692a91749c0b56a6 
>   src/tests/slave_tests.cpp 07145432c35c85a755b66ba575c2a46db072ce5c 
> 
> 
> Diff: https://reviews.apache.org/r/64430/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message