mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Review Request 64445: Renamed resource categories in 'UpdateSlaveMessage'.
Date Fri, 08 Dec 2017 11:32:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64445/
-----------------------------------------------------------

Review request for mesos, Jie Yu and Jan Schlicht.


Bugs: MESOS-8312
    https://issues.apache.org/jira/browse/MESOS-8312


Repository: mesos


Description
-------

In order to support setting either or both oversubscribed or total
resources in 'UpdateSlaveMessage' we introduced resource categories
into the message in the development leading up to 1.5.0. Since we now
do not pass total resources as part of the message anymore we remove
the notion of resource categories and replace them with an optional
boolean value indicating whether to interpret the passed
oversubscribed resources; this allows us to handle messages from
agents not aware of this field and assuming that oversubscribed
resources would always be interpreted.


Diffs
-----

  src/master/master.cpp 5cba50636a9351d29660c54fad7734fcfea547b9 
  src/messages/messages.proto f71178438660fa16aad8f290391baba7813fbff0 
  src/slave/slave.cpp 54d8bcc035227dd6896ffa6e692a91749c0b56a6 
  src/tests/oversubscription_tests.cpp 3f57ce105e24e9f9cd681d8d984dbe242aa51f75 


Diff: https://reviews.apache.org/r/64445/diff/1/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message