mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 64430: Only passed agent's resource version in top-level 'UpdateSlaveMessage'.
Date Fri, 08 Dec 2017 11:32:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64430/
-----------------------------------------------------------

(Updated Dec. 8, 2017, 12:32 p.m.)


Review request for mesos, Jie Yu and Jan Schlicht.


Changes
-------

Rebased.


Summary (updated)
-----------------

Only passed agent's resource version in top-level 'UpdateSlaveMessage'.


Bugs: MESOS-8312
    https://issues.apache.org/jira/browse/MESOS-8312


Repository: mesos


Description
-------

Since we have moved all resource provider-related information like
e.g., resource versions to an explicit field in 'UpdateSlaveMessage',
we now only pass agent information in top-level fields.

To model that we changed the top-level resource versions there from a
repeated field to a single optional field. This will allow us to in
the future pass agent information in the resource provider data
structure as well.


Diffs (updated)
-----

  src/master/master.cpp 5cba50636a9351d29660c54fad7734fcfea547b9 
  src/messages/messages.proto f71178438660fa16aad8f290391baba7813fbff0 
  src/slave/slave.cpp 54d8bcc035227dd6896ffa6e692a91749c0b56a6 
  src/tests/slave_tests.cpp 07145432c35c85a755b66ba575c2a46db072ce5c 


Diff: https://reviews.apache.org/r/64430/diff/2/

Changes: https://reviews.apache.org/r/64430/diff/1-2/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message