mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 64351: Moved generated CSI code into public directories.
Date Thu, 07 Dec 2017 23:31:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64351/
-----------------------------------------------------------

(Updated Dec. 7, 2017, 3:31 p.m.)


Review request for mesos, Chun-Hung Hsiao and Jie Yu.


Changes
-------

Added ugly ugly hack to support building some derivative CSI protobufs as private, while the
3rdparty CSI protobufs are public.


Bugs: MESOS-8251
    https://issues.apache.org/jira/browse/MESOS-8251


Repository: mesos


Description
-------

This moves the Container Storage Interface (CSI) code generated from
its protobufs into the `include` directory so that other public
headers can use them.  The `csi/spec.hpp` was moved too, because
we prefer to include a layer of header indirection when adding
generated headers into non-generated headers.

An upcoming module specifically for CSI support will need to return
objects defined in the CSI specification.  And because modules have
public interfaces, we'll need the generated headers to be public too.


Diffs (updated)
-----

  include/csi/csi.proto PRE-CREATION 
  src/Makefile.am be105f485124579f70888bda69d3c37fd5a18770 
  src/csi/client.hpp 91dda0d44544c8901a9f71ef7f8338205b8ed598 
  src/csi/spec.hpp c819be30312e32275b2d17ade35ba9f500f81b80 
  src/csi/state.proto 0373c8ad217998a54b06d483f94052bcf4293677 
  src/tests/mock_csi_plugin.hpp 162dc6499a7ae880b30ec801ed399b7a3438bdc6 


Diff: https://reviews.apache.org/r/64351/diff/3/

Changes: https://reviews.apache.org/r/64351/diff/2-3/


Testing
-------

See end of chain.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message