mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 64352: Added default VolumeProfile module implementation.
Date Thu, 07 Dec 2017 22:08:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64352/
-----------------------------------------------------------

(Updated Dec. 7, 2017, 2:08 p.m.)


Review request for mesos, Chun-Hung Hsiao and Jie Yu.


Changes
-------

Updated to match changed interface (rename + extra parameter in both module functions).


Bugs: MESOS-8251
    https://issues.apache.org/jira/browse/MESOS-8251


Repository: mesos


Description
-------

By default, Mesos and the Storage Local Resource Provider (SLRP) will
not expect profiles to be used. This is partly due to the experimental
nature of the "profile" field and partly because some explicit operator
intervention is required to get profiles defined. There is no default
profile that is accepted by CSI plugins.


Diffs (updated)
-----

  include/mesos/module/volume_profile.hpp PRE-CREATION 
  src/Makefile.am 05e8b950a3ee13f7b2e8af9416495f2827138449 
  src/resource_provider/volume_profile.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/64352/diff/2/

Changes: https://reviews.apache.org/r/64352/diff/1-2/


Testing
-------

See end of chain.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message