mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 64151: Added a V1 API call to list resource providers.
Date Thu, 07 Dec 2017 14:35:33 GMT


> On Dec. 5, 2017, 6:06 p.m., Benjamin Bannier wrote:
> > src/resource_provider/manager.hpp
> > Lines 28 (patched)
> > <https://reviews.apache.org/r/64151/diff/6/?file=1909010#file1909010line28>
> >
> >     Unused?

The latest rebase no longer changes ResourceProviderManager. Dropping.


> On Dec. 5, 2017, 6:06 p.m., Benjamin Bannier wrote:
> > src/resource_provider/manager.hpp
> > Lines 63 (patched)
> > <https://reviews.apache.org/r/64151/diff/6/?file=1909010#file1909010line63>
> >
> >     Could we explicitly include `mesos.hpp` for `ResourceProviderInfo`?

The latest rebase no longer changes ResourceProviderManager. Dropping.


> On Dec. 5, 2017, 6:06 p.m., Benjamin Bannier wrote:
> > src/resource_provider/manager.cpp
> > Lines 466 (patched)
> > <https://reviews.apache.org/r/64151/diff/6/?file=1909011#file1909011line466>
> >
> >     `foreachvalue`? We should also include `stout/foreach.hpp` here.

The latest rebase no longer changes ResourceProviderManager. Dropping.


> On Dec. 5, 2017, 6:06 p.m., Benjamin Bannier wrote:
> > src/tests/resource_provider_manager_tests.cpp
> > Lines 839 (patched)
> > <https://reviews.apache.org/r/64151/diff/6/?file=1909016#file1909016line839>
> >
> >     Could we use a `MockResourceProvider` here as well?

The latest rebase no longer changes ResourceProviderManager. Dropping.


> On Dec. 5, 2017, 6:06 p.m., Benjamin Bannier wrote:
> > src/tests/resource_provider_manager_tests.cpp
> > Lines 880 (patched)
> > <https://reviews.apache.org/r/64151/diff/6/?file=1909016#file1909016line880>
> >
> >     This needs to be an assert.

The latest rebase no longer changes ResourceProviderManager. Dropping.


> On Dec. 5, 2017, 6:06 p.m., Benjamin Bannier wrote:
> > src/tests/resource_provider_manager_tests.cpp
> > Lines 881 (patched)
> > <https://reviews.apache.org/r/64151/diff/6/?file=1909016#file1909016line881>
> >
> >     This needs to be tweaked if we use a `MockResourceProvider`.

The latest rebase no longer changes ResourceProviderManager. Dropping.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64151/#review192877
-----------------------------------------------------------


On Dec. 7, 2017, 3:32 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64151/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2017, 3:32 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8270
>     https://issues.apache.org/jira/browse/MESOS-8270
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The 'GET_RESOURCE_PROVIDERS' call will list all subscribed local
> resource providers of an agent.
> 
> 
> Diffs
> -----
> 
>   include/mesos/agent/agent.proto 0f92f73ba0f7729f0ba7cd89a692ab3685125e8b 
>   include/mesos/v1/agent/agent.proto 012ffef5f0dd7720fa95ae484c99479aaf256d7b 
>   src/slave/http.hpp a51831cdcebc1998ce6d4c3c19285e598a4ec9a3 
>   src/slave/http.cpp fd0e809d5dc7722e573b66621f75d791f0911dfa 
>   src/slave/validation.cpp 32781fd8f124f71e61744804aec3fe4da59a5df2 
>   src/tests/api_tests.cpp 53c705ed4775846ba7eb42da57f962895f5669aa 
> 
> 
> Diff: https://reviews.apache.org/r/64151/diff/7/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message