mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 63390: Create/destroy volume test for storage local resource provider.
Date Thu, 07 Dec 2017 02:30:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63390/#review193064
-----------------------------------------------------------




src/tests/resource_provider/storage_local_tests.cpp
Lines 1 (patched)
<https://reviews.apache.org/r/63390/#comment271559>

    I'd not introduce the `resource_provider/` directory yet. We'll do that once there are
more tests there.



src/tests/resource_provider/storage_local_tests.cpp
Lines 60-61 (patched)
<https://reviews.apache.org/r/63390/#comment271560>

    I'd suggest we use the libtool wrapper so that you don't have to do the LD_LIBRARY_PATH
trick below because libtool wrapper script does it for you



src/tests/resource_provider/storage_local_tests.cpp
Lines 65-103 (patched)
<https://reviews.apache.org/r/63390/#comment271561>

    You can use string literal and strings::format to make it read nicer



src/tests/resource_provider/storage_local_tests.cpp
Lines 158-161 (patched)
<https://reviews.apache.org/r/63390/#comment271570>

    I'd try to use unversioned API if possible so that we don't have to adjust the tests when
we switch to v3 (deprecating v1)


- Jie Yu


On Dec. 6, 2017, 8:06 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63390/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2017, 8:06 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joseph Wu, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The unit test uses a mock framework to issue `CREATE_VOLUME` and
> `DESTROY_VOLUME` operations to a storage local resource provider, which
> uses the test CSI plugin, to create and destroy a CSI volume.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am d5ca797c5a57a2763374d391a7e9358fe29f5e06 
>   src/examples/test_csi_plugin.cpp 8ab936ba6ba6942452b8cb29bb9a8a4f85c02e53 
>   src/tests/mesos.hpp 3a9b1fbd4301c6cccbc770329ff71ed8ff7e86a2 
>   src/tests/resource_provider/storage_local_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63390/diff/4/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message