mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 63971: Defined a module interface for translating volume profiles.
Date Wed, 06 Dec 2017 23:48:37 GMT


> On Dec. 6, 2017, 6:37 p.m., Jie Yu wrote:
> > include/mesos/resource_provider/volume_profile.hpp
> > Lines 92 (patched)
> > <https://reviews.apache.org/r/63971/diff/3/?file=1909252#file1909252line92>
> >
> >     We chatted about having an ability to define a default profile. To support that,
maybe `profile` here needs to be Optional?
> 
> Joseph Wu wrote:
>     I'm hearing mixed messages about providing a default profile.
>     
>     Sounds like the SLRP could choose to not publish resources if there is no profile.
>     Or the SLRP could set it's own default somewhere.
>     Or the default module implementation could return a (basically hard-coded) value
for all profiles.

Discussed offline. Let's don't support default profile yet. The default BLOCK or VOLUME capabilities
and access mode will be hard coded in SLRP for now (for publishing). Drop it


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63971/#review193013
-----------------------------------------------------------


On Dec. 6, 2017, 11:37 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63971/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2017, 11:37 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jie Yu.
> 
> 
> Bugs: MESOS-8251
>     https://issues.apache.org/jira/browse/MESOS-8251
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This module is currently intended for use by the Storage Local
> Resource Provider (SLRP), but may be used by other components if
> those components use any of the affected Container Storage Interface
> (CSI) requests. The affected calls are listed in the module's comments.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 5b93478ed1a8250b05c44ec8b4d1f660a2053b87 
>   include/mesos/resource_provider/volume_profile.hpp PRE-CREATION 
>   include/mesos/v1/mesos.proto 22b3c6889d975147b001ef145ba4fc382debf70a 
> 
> 
> Diff: https://reviews.apache.org/r/63971/diff/4/
> 
> 
> Testing
> -------
> 
> See end of chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message