mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 63971: Defined a module interface for translating volume profiles.
Date Wed, 06 Dec 2017 23:37:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63971/
-----------------------------------------------------------

(Updated Dec. 6, 2017, 3:37 p.m.)


Review request for mesos, Chun-Hung Hsiao and Jie Yu.


Changes
-------

* Renamed module
* Tweaked some comments
* Pulled return type of `translate` into a struct
* Added parameter for optional filtering by CSI plugin type.


Bugs: MESOS-8251
    https://issues.apache.org/jira/browse/MESOS-8251


Repository: mesos


Description
-------

This module is currently intended for use by the Storage Local
Resource Provider (SLRP), but may be used by other components if
those components use any of the affected Container Storage Interface
(CSI) requests. The affected calls are listed in the module's comments.


Diffs (updated)
-----

  include/mesos/mesos.proto 5b93478ed1a8250b05c44ec8b4d1f660a2053b87 
  include/mesos/resource_provider/volume_profile.hpp PRE-CREATION 
  include/mesos/v1/mesos.proto 22b3c6889d975147b001ef145ba4fc382debf70a 


Diff: https://reviews.apache.org/r/63971/diff/4/

Changes: https://reviews.apache.org/r/63971/diff/3-4/


Testing
-------

See end of chain.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message