mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 63971: Defined a module interface for translating volume profiles.
Date Wed, 06 Dec 2017 20:04:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63971/#review193036
-----------------------------------------------------------




include/mesos/resource_provider/volume_profile.hpp
Lines 104-105 (patched)
<https://reviews.apache.org/r/63971/#comment271529>

    Do we intend to use this module for all LRPs on the agent? If yes, how can we get profiles
for a particular LRP? Should profile name be unique cluster wide, or unique per LRP?
    
    I guess we can assume it's unique per RP. Some distribution might choose to do cluster
wide unique, but that's their choice.
    
    With that in mind, maybe include ResourceProviderInfo in the request?


- Jie Yu


On Dec. 5, 2017, 10:06 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63971/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2017, 10:06 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jie Yu.
> 
> 
> Bugs: MESOS-8251
>     https://issues.apache.org/jira/browse/MESOS-8251
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This module is currently intended for use by the Storage Local
> Resource Provider (SLRP), but may be used by other components if
> those components use any of the affected Container Storage Interface
> (CSI) requests. The affected calls are listed in the module's comments.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 5b93478ed1a8250b05c44ec8b4d1f660a2053b87 
>   include/mesos/resource_provider/volume_profile.hpp PRE-CREATION 
>   include/mesos/v1/mesos.proto 22b3c6889d975147b001ef145ba4fc382debf70a 
> 
> 
> Diff: https://reviews.apache.org/r/63971/diff/3/
> 
> 
> Testing
> -------
> 
> See end of chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message