mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 64352: Added default VolumeProfile module implementation.
Date Wed, 06 Dec 2017 18:56:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64352/#review193017
-----------------------------------------------------------




src/resource_provider/volume_profile.cpp
Lines 53-54 (patched)
<https://reviews.apache.org/r/64352/#comment271503>

    See my comments in the previous patch regarding default profile.
    
    For default volume profile adaptor, if `profile` is None(), simply return None() indicating
that default profile is not supported (rather than returning a failure)?
    
    That means no resource will be sent out using default volume profile adaptor?
    
    That makes me wondering why we need a default volume provider adaptor. Can you just make
the uri voluem profiler adaptor the default?


- Jie Yu


On Dec. 5, 2017, 10:09 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64352/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2017, 10:09 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jie Yu.
> 
> 
> Bugs: MESOS-8251
>     https://issues.apache.org/jira/browse/MESOS-8251
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> By default, Mesos and the Storage Local Resource Provider (SLRP) will
> not expect profiles to be used. This is partly due to the experimental
> nature of the "profile" field and partly because some explicit operator
> intervention is required to get profiles defined. There is no default
> profile that is accepted by CSI plugins.
> 
> 
> Diffs
> -----
> 
>   include/mesos/module/volume_profile.hpp PRE-CREATION 
>   src/Makefile.am 05e8b950a3ee13f7b2e8af9416495f2827138449 
>   src/resource_provider/volume_profile.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64352/diff/1/
> 
> 
> Testing
> -------
> 
> See end of chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message